chronicle executor spawns tasks with structured logs #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvc94ch
reviewed
Jun 27, 2024
chronicle/src/tasks/executor.rs
Outdated
| }; | ||
| self.task_spawner.execute_sign(shard_id, task_id, payload.into(), block_number) | ||
| }, | ||
| TaskPhase::Write => { | ||
| let Some(public_key) = self.substrate.get_task_signer(task_id).await? else { | ||
| tracing::warn!("no signer set for write phase"); | ||
| tracing::warn!("no signer set for write phase for task {task_id}"); |
There was a problem hiding this comment.
we want a structured log, see how it's done in the chronicle service. something along the lines of task_id=task_id
4meta5
changed the title
dvc94ch
approved these changes
Jul 2, 2024
This was referenced Jul 2, 2024
|
This seems to have broken my clippy... |
|
Looks like CI is broken |
11 tasks
FlorianFranzen
added a commit
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #958 to structure logs for executor when spawning tasks, should facilitate debugging