Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shard partial offline state #923

Merged
merged 13 commits into from
Jun 13, 2024

Conversation

4meta5
Copy link
Contributor

@4meta5 4meta5 commented Jun 11, 2024

Closes #924 to prevent confusion regarding the task assignability of these shards

@4meta5 4meta5 added the bug Something isn't working label Jun 11, 2024
@4meta5 4meta5 added this to the Milestone Q2 2024 milestone Jun 11, 2024
@4meta5 4meta5 self-assigned this Jun 11, 2024
@4meta5 4meta5 marked this pull request as ready for review June 12, 2024 02:44
@4meta5 4meta5 requested a review from dvc94ch June 12, 2024 02:44
@4meta5
Copy link
Contributor Author

4meta5 commented Jun 12, 2024

debugging failing unit tests WIP

Copy link
Collaborator

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thx

@4meta5 4meta5 merged commit 692ce9f into development Jun 13, 2024
7 checks passed
@4meta5 4meta5 deleted the amar-rm-partial-shard-offline-state branch June 13, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ShardStatus::PartialOffline
2 participants