Fix benchmarking (on top of v2)

[4meta5]

Benchmarking on top of #1128

• fix tasks submit_result benchmark
• (WIP) Benchmark-derived tasks scheduling weight (v2) #1155
• (WIP) Bound number of tasks scheduled per block #1159

[4meta5]

one of the CI errors cc @penumbra23 OOM error I think:

Failed to allocate memory: "Allocator ran out of space"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at cli/main.rs:324:10:
called `Result::unwrap()` on an `Err` value: Input("failed to execute TryRuntime_on_runtime_upgrade: Execution aborted due to trap: host code panicked while being called by the runtime: Failed to allocate memory: \"Allocator ran out of space\"\nWASM backtrace:\nerror while executing at wasm backtrace:\n    0: 0x53255 - testnet_runtime.wasm!sp_io::allocator::extern_host_function_impls::malloc::h42320f5a9c32ecf6\n    1: 0x53714 - testnet_runtime.wasm!<alloc::vec::Vec<T> as parity_scale_codec::codec::Decode>::decode::hc1f97cfa6e79c1f1\n    2: 0x52b73 - testnet_runtime.wasm!<core::option::Option<T> as parity_scale_codec::codec::Decode>::decode::h726b157f91de5048\n    3: 0x5383a - testnet_runtime.wasm!<sp_runtime_interface::pass_by::Codec<T> as sp_runtime_interface::pass_by::PassByImpl<T>>::from_ffi_value::h0e0aeed8b84ae42b\n    4: 0x52fea - testnet_runtime.wasm!sp_io::storage::extern_host_function_impls::next_key::hcac64ee6d590c8ee\n    5: 0x1633a1 - testnet_runtime.wasm!frame_support::traits::try_runtime::decode_entire_state::decode_storage_info::h479266be4ef70d9e\n    6: 0x23561d - testnet_runtime.wasm!<frame_support::storage::types::map::StorageMap<Prefix,Hasher,Key,Value,QueryKind,OnEmpty,MaxValues> as frame_support::traits::try_runtime::decode_entire_state::TryDecodeEntireStorage>::try_decode_entire_state::h94a336411f5805c8\n    7: 0x1d1555 - testnet_runtime.wasm!<pallet_tasks::pallet::Pallet<T> as frame_support::traits::try_runtime::decode_entire_state::TryDecodeEntireStorage>::try_decode_entire_state::h7f6eced46ad7d571\n    8: 0x102f5c - testnet_runtime.wasm!<(TupleElement0,TupleElement1,TupleElement2,TupleElement3,TupleElement4,TupleElement5,TupleElement6,TupleElement7,TupleElement8,TupleElement9,TupleElement10,TupleElement11,TupleElement12,TupleElement13,TupleElement14,TupleElement15,TupleElement16,TupleElement17,TupleElement18,TupleElement19,TupleElement20,TupleElement21,TupleElement22,TupleElement23,TupleElement24,TupleElement25) as frame_support::traits::try_runtime::decode_entire_state::TryDecodeEntireStorage>::try_decode_entire_state::ha49997313dc0cf96\n    9: 0x2bc6d9 - testnet_runtime.wasm!frame_executive::Executive<System,Block,Context,UnsignedValidator,AllPalletsWithSystem,COnRuntimeUpgrade>::try_runtime_upgrade::hcb2b5a08e7265261\n   10: 0xa3c67 - testnet_runtime.wasm!<testnet_runtime::Runtime as frame_try_runtime::inner::runtime_decl_for_try_runtime::TryRuntimeV1<sp_runtime::generic::block::Block<sp_runtime::generic::header::Header<u32,sp_runtime::traits::BlakeTwo256>,sp_runtime::generic::unchecked_extrinsic::UncheckedExtrinsic<sp_runtime::multiaddress::MultiAddress<<<sp_runtime::MultiSignature as sp_runtime::traits::Verify>::Signer as sp_runtime::traits::IdentifyAccount>::AccountId,()>,testnet_runtime::RuntimeCall,sp_runtime::MultiSignature,(frame_system::extensions::check_non_zero_sender::CheckNonZeroSender<testnet_runtime::Runtime>,frame_system::extensions::check_spec_version::CheckSpecVersion<testnet_runtime::Runtime>,frame_system::extensions::check_tx_version::CheckTxVersion<testnet_runtime::Runtime>,frame_system::extensions::check_genesis::CheckGenesis<testnet_runtime::Runtime>,frame_system::extensions::check_mortality::CheckMortality<testnet_runtime::Runtime>,frame_system::extensions::check_nonce::CheckNonce<testnet_runtime::Runtime>,frame_system::extensions::check_weight::CheckWeight<testnet_runtime::Runtime>,pallet_transaction_payment::ChargeTransactionPayment<testnet_runtime::Runtime>,frame_metadata_hash_extension::CheckMetadataHash<testnet_runtime::Runtime>)>>>>::on_runtime_upgrade::h4cfa5e33537d54b7\n   11: 0x24405a - testnet_runtime.wasm!TryRuntime_on_runtime_upgrade")

I also expect to get a benchmarking error due to some misconfiguration: #1140 (comment)

[penumbra23]

one of the CI errors cc @penumbra23 OOM error I think:

Failed to allocate memory: "Allocator ran out of space"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at cli/main.rs:324:10:
called `Result::unwrap()` on an `Err` value: Input("failed to execute TryRuntime_on_runtime_upgrade: Execution aborted due to trap: host code panicked while being called by the runtime: Failed to allocate memory: \"Allocator ran out of space\"\nWASM backtrace:\nerror while executing at wasm backtrace:\n    0: 0x53255 - testnet_runtime.wasm!sp_io::allocator::extern_host_function_impls::malloc::h42320f5a9c32ecf6\n    1: 0x53714 - testnet_runtime.wasm!<alloc::vec::Vec<T> as parity_scale_codec::codec::Decode>::decode::hc1f97cfa6e79c1f1\n    2: 0x52b73 - testnet_runtime.wasm!<core::option::Option<T> as parity_scale_codec::codec::Decode>::decode::h726b157f91de5048\n    3: 0x5383a - testnet_runtime.wasm!<sp_runtime_interface::pass_by::Codec<T> as sp_runtime_interface::pass_by::PassByImpl<T>>::from_ffi_value::h0e0aeed8b84ae42b\n    4: 0x52fea - testnet_runtime.wasm!sp_io::storage::extern_host_function_impls::next_key::hcac64ee6d590c8ee\n    5: 0x1633a1 - testnet_runtime.wasm!frame_support::traits::try_runtime::decode_entire_state::decode_storage_info::h479266be4ef70d9e\n    6: 0x23561d - testnet_runtime.wasm!<frame_support::storage::types::map::StorageMap<Prefix,Hasher,Key,Value,QueryKind,OnEmpty,MaxValues> as frame_support::traits::try_runtime::decode_entire_state::TryDecodeEntireStorage>::try_decode_entire_state::h94a336411f5805c8\n    7: 0x1d1555 - testnet_runtime.wasm!<pallet_tasks::pallet::Pallet<T> as frame_support::traits::try_runtime::decode_entire_state::TryDecodeEntireStorage>::try_decode_entire_state::h7f6eced46ad7d571\n    8: 0x102f5c - testnet_runtime.wasm!<(TupleElement0,TupleElement1,TupleElement2,TupleElement3,TupleElement4,TupleElement5,TupleElement6,TupleElement7,TupleElement8,TupleElement9,TupleElement10,TupleElement11,TupleElement12,TupleElement13,TupleElement14,TupleElement15,TupleElement16,TupleElement17,TupleElement18,TupleElement19,TupleElement20,TupleElement21,TupleElement22,TupleElement23,TupleElement24,TupleElement25) as frame_support::traits::try_runtime::decode_entire_state::TryDecodeEntireStorage>::try_decode_entire_state::ha49997313dc0cf96\n    9: 0x2bc6d9 - testnet_runtime.wasm!frame_executive::Executive<System,Block,Context,UnsignedValidator,AllPalletsWithSystem,COnRuntimeUpgrade>::try_runtime_upgrade::hcb2b5a08e7265261\n   10: 0xa3c67 - testnet_runtime.wasm!<testnet_runtime::Runtime as frame_try_runtime::inner::runtime_decl_for_try_runtime::TryRuntimeV1<sp_runtime::generic::block::Block<sp_runtime::generic::header::Header<u32,sp_runtime::traits::BlakeTwo256>,sp_runtime::generic::unchecked_extrinsic::UncheckedExtrinsic<sp_runtime::multiaddress::MultiAddress<<<sp_runtime::MultiSignature as sp_runtime::traits::Verify>::Signer as sp_runtime::traits::IdentifyAccount>::AccountId,()>,testnet_runtime::RuntimeCall,sp_runtime::MultiSignature,(frame_system::extensions::check_non_zero_sender::CheckNonZeroSender<testnet_runtime::Runtime>,frame_system::extensions::check_spec_version::CheckSpecVersion<testnet_runtime::Runtime>,frame_system::extensions::check_tx_version::CheckTxVersion<testnet_runtime::Runtime>,frame_system::extensions::check_genesis::CheckGenesis<testnet_runtime::Runtime>,frame_system::extensions::check_mortality::CheckMortality<testnet_runtime::Runtime>,frame_system::extensions::check_nonce::CheckNonce<testnet_runtime::Runtime>,frame_system::extensions::check_weight::CheckWeight<testnet_runtime::Runtime>,pallet_transaction_payment::ChargeTransactionPayment<testnet_runtime::Runtime>,frame_metadata_hash_extension::CheckMetadataHash<testnet_runtime::Runtime>)>>>>::on_runtime_upgrade::h4cfa5e33537d54b7\n   11: 0x24405a - testnet_runtime.wasm!TryRuntime_on_runtime_upgrade")

I also expect to get a benchmarking error due to some misconfiguration: #1140 (comment)

I re-run the pipeline and observed the agent resources, nothing spikes. Need to investigate this more a bit.

[dvc94ch]

merged into v2

[4meta5]

Why was it closed if it was merged into v2?