Replace inflationary task funding with treasury-funded task creation #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e storage changes below fallible calls
…/Analog-Labs/timechain into amar-new-task-funding-mechanisms
4meta5
commented
Aug 2, 2024
Closed
3 tasks
4meta5
commented
Aug 5, 2024
4meta5
commented
Aug 5, 2024
4meta5
changed the title
4meta5
added
the
ready-for-review
|
WIP and Ready for Review because the implementation is ready for review, but there are remaining TODOs before we merge (listed in PR description). |
4meta5
commented
Aug 12, 2024
4meta5
commented
Aug 13, 2024
| @@ -216,6 +216,5 @@ pub struct RewardConfig<Balance, BlockNumber> { | |||
| #[derive(Debug, Clone, Decode, Encode, TypeInfo, PartialEq, Eq, PartialOrd, Ord)] | |||
| pub enum TaskFunder { | |||
| Account(AccountId), | |||
There was a problem hiding this comment.
NOTE for reviewers that, after the changes in this PR, this variant is only used when create_task is called
4meta5
requested review from
dvc94ch,
FlorianFranzen and
taniasaleem
and removed request for
dvc94ch and
FlorianFranzen
dvc94ch
approved these changes
Aug 14, 2024
| /// Insufficient Treasury Balance to create UnRegisterShard task | ||
| InsufficientTreasuryBalanceToUnRegisterShard(ShardId), | ||
| /// Insufficient Treasury Balance To Create SendMessage task as an effect of calling `submit_result` | ||
| InsufficientTreasuryBalanceToSendMessage(Msg), | ||
| } |
There was a problem hiding this comment.
Registering and unregistering of shards should be funded from the shards' stake.
SendMessage is the execution of a GMP message; its cost should be covered by the chronicle, and oracle will reimburse.
Treasury fund should only be used for root calls required for system working.
ManojJiSharma
pushed a commit
that referenced
this pull request
Aug 28, 2024
…1042) Co-authored-by: Metadata Update Bot <[email protected]> Co-authored-by: Github Actions <41898282+github-actions[bot]@users.noreply.github.com>
ManojJiSharma
pushed a commit
that referenced
this pull request
Aug 29, 2024
…1042) Co-authored-by: Metadata Update Bot <[email protected]> Co-authored-by: Github Actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP Closes #1040
Also closes #760 by removing all task funding via inflation
recv_msgoperation due to submit_result from the Treasurysend_messagefrom the Treasuryrecv_msgoperation due to register_gateway from the Treasury, propagate error if insufficient balance & move storage changes to after this fallible callNotes for Research
Significantly simplified design by David's suggestion to fund all task creation outside of
create_taskvia the Treasury. This handles a lot of edge case handling that was discussed before.The impact is that it adds the requirement that we always keep the Treasury well funded to our list of operational requirements. There are events and errors that will be emitted when/if the Treasury is not well funded, but we should ensure it is via by balancing funds regularly.
create_taskis the only path that funds task creation from the caller. This flow would be effected by #1065 which should probably make all task creation funded by the treasury, which could simplify much of the code by removingTaskFunderand its usage altogether.