mainnet-runtime: add full sudo replacment #1029
Conversation
FlorianFranzen
force-pushed
the
florian/mainnet-sudo
branch
from
c2fd261 to
b787e36
Compare
There was a problem hiding this comment.
Much easier to review if the PR splits changes into separate PRs that are scoped such that there is 1-2 issues solved per PR.
Batching these changes makes it a lot harder to review. Only saying this because I approved a PR last week which ignored benchmarks and I did not notice until I had to fix them this week.
FlorianFranzen
force-pushed
the
florian/mainnet-sudo
branch
from
aeab7f1 to
95f51a3
Compare
FlorianFranzen
force-pushed
the
florian/mainnet-sudo
branch
from
95f51a3 to
3eb0613
Compare
penumbra23
added
!ci-test-basic
FlorianFranzen
force-pushed
the
florian/mainnet-sudo
branch
from
2167495 to
b31adb5
Compare
FlorianFranzen
force-pushed
the
florian/mainnet-sudo
branch
from
da64a78 to
b715b01
Compare
FlorianFranzen
added
!ci-test-basic
There was a problem hiding this comment.
I do not see the new governance pallet configured in either runtime.
This PR already contains a lot of changes, maybe we could split the new governance pallet out into a separate PR alongside its configuration in the runtimes? That would facilitate better reviews of this new pallet cc @0x1100010010
|
Merged for now, as integration test runs fine on my end, but is broken on CI. |
Co-authored-by: Metadata Update Bot <[email protected]>
Co-authored-by: Metadata Update Bot <[email protected]>
Description
This PR focuses on adding a sudo replacement using the technical collective.
Needed to update to 1.14.0 so I could use pallet_membership as tippers.
Still needs a few smaller fixes and some more testing,