Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tasks funding mechanism #1018

Closed

Conversation

taniasaleem123
Copy link
Contributor

@taniasaleem123 taniasaleem123 commented Jul 22, 2024

Description

This provides the updates that need to be done in the tasks pallet regarding the task funding.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Code review prechecks:

  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings

@taniasaleem123 taniasaleem123 marked this pull request as draft July 22, 2024 06:47
@taniasaleem123 taniasaleem123 marked this pull request as ready for review July 29, 2024 15:47
//!- **Description**: Fund the `recv_msg` operation from the caller account.
//!- **Specification**: Ensure that the cost for the `recv_msg` operation is covered by the caller, similar to `register_gateway` and `submit_result`. The caller is the root and shard member in the cases of `register_gateway` and `submit_result`, respectively.
//!
//!## Not Feature: Estimations of Required Funds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like it should be an issue, not organized in the crate-level docs IMO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We plan to include a section for planned features in docs and after that, these can be picked to create issues based on development priority.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should start as issues and be turned into docs only after the implementation

@@ -39,6 +39,59 @@
//! number of tasks to be reset is reached.
#![doc = simple_mermaid::mermaid!("../docs/reset_tasks.mmd")]

//!## Future Features
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't these all be issues? I don't see the value of adding planned features with planned specs to the crate-level docs?

@dvc94ch
Copy link
Collaborator

dvc94ch commented Jul 30, 2024

agree with amar. think this would be better as github issues.

@4meta5
Copy link
Contributor

4meta5 commented Jul 30, 2024

Closing this and opening issues with the content as commented on above.

After we implement it & merge the implementation, @taniasaleem can add crate-level docs describing it as it is implemented

@4meta5 4meta5 closed this Jul 30, 2024
@4meta5 4meta5 deleted the research/task-pallet-improvment-proposal branch July 30, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants