Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix task distribution #1013

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Fix task distribution #1013

merged 5 commits into from
Jul 19, 2024

Conversation

haider-rs
Copy link
Contributor

@haider-rs haider-rs commented Jul 19, 2024 •
edited
Loading

Description

This PR fixes incorrect task distribution among shards and adds unit tests

Fixes # (issue)

#998

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:

Code review prechecks:

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings
  • Test cases have been added
  • Dependent changes have been merged and published in downstream modules

@haider-rs haider-rs self-assigned this Jul 19, 2024
@haider-rs haider-rs linked an issue Jul 19, 2024 that may be closed by this pull request
Task assignment to shards NOT balanced #998
Closed
@haider-rs haider-rs force-pushed the fix-task-distribution branch from 2fb7773 to 6d33940 Compare July 19, 2024 13:21
4meta5
4meta5 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@4meta5 4meta5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tested locally by changing the starting conditions, seems to work consistently even after these changes

@4meta5 4meta5 mentioned this pull request Jul 19, 2024
Closed
3 tasks
@haider-rs haider-rs force-pushed the fix-task-distribution branch from 5629675 to 314ad55 Compare July 19, 2024 13:45
@haider-rs haider-rs force-pushed the fix-task-distribution branch from d87c8d0 to 887c49b Compare July 19, 2024 13:57
@haider-rs haider-rs merged commit d8a2e1b into development Jul 19, 2024
@haider-rs haider-rs deleted the fix-task-distribution branch July 19, 2024 14:41
@penumbra23 penumbra23 mentioned this pull request Jul 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4meta5 4meta5 4meta5 approved these changes

Assignees

@haider-rs haider-rs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task assignment to shards NOT balanced
2 participants
@haider-rs @4meta5