runtimes: add template mainnet runtime #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianFranzen
changed the title
FlorianFranzen
force-pushed
the
florian/mainnet-runtime
branch
from
cbceec7 to
aa4c644
Compare
FlorianFranzen
added
enhancement
FlorianFranzen
force-pushed
the
florian/mainnet-runtime
branch
from
0c51602 to
8c7a958
Compare
FlorianFranzen
force-pushed
the
florian/mainnet-runtime
branch
from
8c7a958 to
4be8e8b
Compare
FlorianFranzen
added
the
ready-for-review
penumbra23
reviewed
Jul 19, 2024
| .runtime_api() | ||
| .account_nonce(best_hash, account.public().into()) | ||
| .expect("Fetching account nonce works; qed") | ||
| //client |
There was a problem hiding this comment.
If it does't give additional context or isn't being restored in future, I would delete comments in general
There was a problem hiding this comment.
Yeah, we will need to restore that too. Commenting it out was of the first attempts to get it to compile at least.
penumbra23
reviewed
Jul 19, 2024
| let db = partial.backend.expose_db(); | ||
| let storage = partial.backend.expose_storage(); | ||
|
|
||
| cmd.run(config, partial.client, db, storage) | ||
| }, | ||
| BenchmarkCmd::Overhead(cmd) => { | ||
| /*BenchmarkCmd::Overhead(cmd) => { |
There was a problem hiding this comment.
Did these commands work at some point? Can't remember being used anywhere
There was a problem hiding this comment.
Not sure if they were part of it before, but we might want to use some of them to really benchmark the chain.
penumbra23
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This add an initial template for the mainnet runtime. There are still a few smaller things missing, most notably separate genesis jsons for mainnet and testnet.
I opened the PR mostly to test early CI integration.
Type of change
Tests
Code still undergoes many changes, additional testing will be done once everything is ready.
Code review prechecks: