support tx subscriptions #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the CI rust version is outdated, will update an run CI checks again. |
Lohann
force-pushed
the
feature/support-tx-subscriptions
branch
from
27f0a4f to
30b18df
Compare
|
DO NOT MERGE YET, this PR contains breaking changes to the timechain, will merge this as soon as I have the PR ready on the timechain repo. |
|
I've found why arbitrum tests were failing... seems it have custom tx types: This issue already existed before, the tests catches it now because now the connector verifies the transaction type and hash before returning it... It basically means that the arbitrum support is incomplete, will disable arbitrum support for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow subscriptions for Ethereum and Astar connector