View documents in new tab #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NvdLaan
reviewed
Sep 18, 2024
app/web/cases/views.py
Outdated
Comment on lines
1294
to
1314
| qs = Case._default_manager.by_user(user=request.user) | ||
| case = qs.filter(pk=case_pk).first() | ||
| if not case: | ||
| raise PermissionDenied | ||
| document = get_object_or_404(Document, id=document_pk) | ||
|
|
||
| if any(user_type in [WONEN, WONINGCORPORATIE_MEDEWERKER] for user_type in request.user.user_type_values): | ||
| form_status_list = [f[0] for f in case.casestatus_set.all().order_by('form').distinct().values_list('form')] | ||
| shared_in_forms = [f for f in document.forms if f in form_status_list] | ||
| if not shared_in_forms: | ||
| raise PermissionDenied | ||
|
|
||
| if document.case != case: | ||
| raise PermissionDenied | ||
|
|
||
| if not default_storage.exists(default_storage.generate_filename(document.uploaded_file.name)): | ||
| raise Http404() | ||
|
|
||
| # Open the file and adjust the content type to match the file type | ||
| with default_storage.open(document.uploaded_file.name, 'rb') as file: | ||
| file_data = file.read() |
There was a problem hiding this comment.
Deze code kan je nog lostrekken naar een aparte methode, is exact hetzelfde als in de download volgens mij
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.