Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(poc): Use our interactive colour for the border of Inputs #1844

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

VincentSmedinga
Copy link
Contributor

@VincentSmedinga VincentSmedinga commented Feb 1, 2025

Describe the pull request

Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.

What

This shows how our inputs would appear if we made their borders blue like inputs, buttons and form controls.

Why

To evaluate whether we want to go through with this.

How

  • Use the default interactive colour for the borders of Date Input, File Input, Password Input, Search Field, Select, Text Area, Text Input, and Time Input.
  • Make the borders a pixel thicker in the process – we rarely use 1px, and rightly so: it looks too feeble in combination with our large text sizes.

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant