chore: Filter ‘default’ suffix from CSS custom properties and Sass / JS variables #1834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
This filters the 'default' suffix from CSS custom properties and Sass / JS variables when generating our tokens.
So
ams.color.default
becomes--ams-color
andamsColor
.Why
We're remodelling our brand and common tokens, and because of how JSON works, we need to use 'default' a lot.
This isn't necessary for tokens though, so this change filters that out.
How
By adding custom transform functions to our Style Dictionary build.
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary: