transition existing vue app to new modernized gauge API #591
Conversation
…le edit, cancel, save
ngottlieb
force-pushed
the
feature/migrate-to-modernized-gauge-api
branch
from
f0d6283 to
edb631a
Compare
| @@ -25,6 +25,8 @@ | |||
| "@mapbox/mapbox-gl-draw": "^1.1.2", | |||
| "@mapbox/mapbox-gl-draw-static-mode": "^1.0.1", | |||
| "@tinymce/tinymce-vue": "^3.2.8", | |||
| "@trpc/client": "^11.0.0-next-beta.264", | |||
| "@trpc/server": "^11.0.0-next-beta.264", | |||
There was a problem hiding this comment.
Does the vue app need to depend on the server?
There was a problem hiding this comment.
yeah, unfortunately you can't just use the client
| @@ -25,6 +25,8 @@ | |||
| "@mapbox/mapbox-gl-draw": "^1.1.2", | |||
| "@mapbox/mapbox-gl-draw-static-mode": "^1.0.1", | |||
| "@tinymce/tinymce-vue": "^3.2.8", | |||
| "@trpc/client": "^11.0.0-next-beta.264", | |||
There was a problem hiding this comment.
I recall having issues with diverging versions. Right now, everything else is on 10.43.0 should we standardize?
There was a problem hiding this comment.
I'll drop back to 10.43 and report back if I have any issues!
| }), | ||
| readingIsEstimated () { | ||
| return this.river?.readingsummary?.gauge_estimated | ||
| // TODO: decide how to handle secondary gauges. do we fall back if primary isn't reporting? |
There was a problem hiding this comment.
cc @AWKevin - I think we decided that not falling back is ultimately more clear.
ngottlieb
force-pushed
the
feature/migrate-to-modernized-gauge-api
branch
from
7e08087 to
b3ce1d4
Compare
| }, | ||
| adjustedReachGrade () { | ||
| if (this.gaugeCorrelation && this.gaugeCorrelation.status && this.gaugeCorrelation.correlationDetails) { | ||
| const adjustedGradeKey = this.gaugeCorrelation.status.status.replace(/-([a-z])/g, g => g[1].toUpperCase()); |
There was a problem hiding this comment.
We can probably render something different serverside if that's helpful?
|
@tallowen I guess broadly speaking, I was imagining I would finish the read components of https://github.com/orgs/AmericanWhitewater/projects/4?pane=issue&itemId=57895707 (i.e. everything except the edit flows interface) before we launched it. And that we would take some steps to establish that we were, I guess, ready to be in "production mode" with the new gauge API. but maybe I'm overthinking and we should just go for it? not a lot to lose... |
|
Makes sense! I think there are a couple things to get done on the backend before general availability but I'd love to start trying the read versions on beta or something. |
ngottlieb
force-pushed
the
feature/migrate-to-modernized-gauge-api
branch
from
2e0a078 to
b7d55ca
Compare
ngottlieb
force-pushed
the
feature/migrate-to-modernized-gauge-api
branch
from
ad905b5 to
2cff69b
Compare
This reverts commit c1af6c8.
* bring state listing into vue app * first work to move state river list into vue * add flow data rendering to the state reach list
…etails are edited
This PR will hold most of the changes for #585, but not the edit flows interface (since that can be released separately, later, if needed).
Currently, it includes: