UX/ Reduce RPC error banners #1210
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borislav-itskov
requested changes
Jan 14, 2025
| @@ -189,6 +193,7 @@ export class SignAccountOpController extends EventEmitter { | |||
| super() | |||
|
|
|||
| this.#accounts = accounts | |||
| this.#providers = providers | |||
There was a problem hiding this comment.
@PetromirDev maybe you had an idea here and forgot to remove the providers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
Account states are updated every 5 minutes automatically and on manual refresh on the dashboard. When the user is simply browsing on his laptop, the account state update fails in the background and the user decides to open his wallet to check how his portfolio is going he will see an RPC error banner, even if there was a successful update 5 minutes ago.
The solution
Save an update timestamp and compare it before displaying an RPC error banner. If the last update is from > 8 minutes ago, an error banner is displayed. Also, the banner is displayed immediately in case of a manual refresh on the dashboard as a bad RPC means that there will be portfolio and defi positions banners, which must be replaced with a single RPC error banner for better UX.
Closes https://github.com/AmbireTech/ambire-app/issues/3105