Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use clickhouse-server container image instead of clickhouse-client #1082

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

CaptTofu
Copy link
Contributor

  1. clickhouse-client container for the cron job wouldn't run in aws-dev-eu, which uses arm64, switched to clickhouse-server container and it works
  2. Added more information and elaboration for the backup process using the operator

@CaptTofu
Copy link
Contributor Author

Re-created this PR because when I rebased my fork with master, somehow it pulled in recent changes which showed up in the original PR.

@CaptTofu CaptTofu force-pushed the k8s-image-document-fix branch from d85fbce to 26376c4 Compare January 30, 2025 14:23
@CaptTofu CaptTofu force-pushed the k8s-image-document-fix branch from 26376c4 to 7b49058 Compare January 30, 2025 14:25
@Slach Slach self-requested a review January 30, 2025 16:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13054457545

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 278 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-2.0%) to 66.306%

Files with Coverage Reduction New Missed Lines %
pkg/clickhouse/clickhouse.go 2 73.84%
cmd/clickhouse-backup/main.go 2 79.69%
pkg/storage/object_disk/object_disk.go 7 68.38%
pkg/config/config.go 8 73.23%
pkg/status/status.go 9 70.2%
pkg/backup/restore.go 9 67.46%
pkg/backup/backuper.go 17 70.92%
pkg/server/server.go 18 58.0%
pkg/storage/general.go 20 59.6%
pkg/storage/s3.go 25 45.98%
Totals Coverage Status
Change from base Build 13015073872: -2.0%
Covered Lines: 9249
Relevant Lines: 13949

💛 - Coveralls

@@ -319,7 +323,7 @@ spec:
restartPolicy: Never
containers:
- name: run-backup-cron
image: clickhouse/clickhouse-client:latest
image: clickhouse/clickhouse-server:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old clickhouse-client should works with new clickhouse-server
which kind of issue you got here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. got it
https://hub.docker.com/r/clickhouse/clickhouse-client/tags
doesn't support arm64
let's add comment here

@Slach Slach merged commit 193c9a5 into Altinity:master Jan 31, 2025
22 checks passed
@Slach
Copy link
Collaborator

Slach commented Jan 31, 2025

thanks for contribution

Slach added a commit that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants