Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pgalbraith backup doc container doc fix #1081

Conversation

CaptTofu
Copy link
Contributor

I needed to use clickhouse-server container image instead of clickhouse-client image, which the latter didn't work in aws-dev-eu because of it being arm64. I also elaborated how the process works a bit more.

Slach and others added 24 commits January 29, 2025 13:21
…ed files to avoid too large numbers in logs

Signed-off-by: Slach <[email protected]>
Signed-off-by: Slach <[email protected]>
…ration and significant decrease memory usage during upload and download, fix [854](Altinity#854)

Signed-off-by: Slach <[email protected]>
Signed-off-by: Slach <[email protected]>
Signed-off-by: Slach <[email protected]>
…nly` options to `upload` and `download` command, fix Altinity#1042

Signed-off-by: Slach <[email protected]>
…ands, with table pattern to allow make backup without projection fix Altinity#861

Signed-off-by: Slach <[email protected]>
…mmands, with table pattern to allow make backup

  without projection, restore supported only in `clickhouse-server` 24.3+, fix Altinity#861

Signed-off-by: Slach <[email protected]>
Replace `backups` dir name with `backup` in command example.
…doesn't work in k8s clusters running arm64 arch
@Slach Slach self-requested a review January 30, 2025 03:08
@Slach
Copy link
Collaborator

Slach commented Jan 30, 2025

looks weird, how did you make 24 commits instead of just last two

@@ -319,7 +321,7 @@ spec:
restartPolicy: Never
containers:
- name: run-backup-cron
image: clickhouse/clickhouse-client:latest
image: clickhouse/clickhouse-server:latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add comment here about clickhouse-client doesn't support anymore, to avoid comments about "ah why you run second clickhouse-server?"

actually old clickhouse-clients should connect to latest clickhouse-server, protocol compatible, which kind of issue did you look here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my issue was that the container in the cron was failing with an odd 'bash exec' issue when I tried running the container in kubernetes with a simple bash while loop to test in aws-dev-eu (which the nodes are arm64). Some searching and a test on my own laptop (which is arm64) gave me the same error, then I realized that the clickhouse-client container didn't run on arm64. Both Anselmo and Josh pointed out what I had suspected and suggested clickhouse-server

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. got it
https://hub.docker.com/r/clickhouse/clickhouse-client/tags
doesn't support arm64, lets add comment here

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13044819465

Details

  • 263 of 367 (71.66%) changed or added relevant lines in 21 files are covered.
  • 1639 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-2.0%) to 66.284%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/clickhouse-backup/main.go 6 7 85.71%
pkg/backup/watch.go 2 3 66.67%
pkg/storage/general.go 8 9 88.89%
pkg/resumable/state.go 5 8 62.5%
pkg/storage/s3.go 23 26 88.46%
pkg/backup/create.go 11 15 73.33%
pkg/storage/cos.go 0 4 0.0%
pkg/storage/gcs.go 0 4 0.0%
pkg/storage/object_disk/object_disk.go 3 7 42.86%
pkg/filesystemhelper/filesystemhelper.go 59 66 89.39%
Files with Coverage Reduction New Missed Lines %
pkg/storage/cos.go 1 0.0%
pkg/backup/delete.go 4 64.94%
pkg/resumable/state.go 4 72.3%
pkg/status/status.go 9 70.2%
pkg/backup/backuper.go 17 70.92%
cmd/clickhouse-backup/main.go 21 79.69%
pkg/storage/azblob.go 23 60.0%
pkg/storage/object_disk/object_disk.go 35 68.38%
pkg/storage/general.go 41 59.6%
pkg/filesystemhelper/filesystemhelper.go 61 63.77%
Totals Coverage Status
Change from base Build 13015073872: -2.0%
Covered Lines: 9246
Relevant Lines: 13949

💛 - Coveralls

@CaptTofu
Copy link
Contributor Author

looks weird, how did you make 24 commits instead of just last two

yes, I didn't realize this. I did a rebase of my fork, I'll redo this.

@CaptTofu CaptTofu closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants