Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support eflo in centralized IPAM #787

Merged
merged 8 commits into from
Feb 24, 2025
Merged

Conversation

l1b0k
Copy link
Collaborator

@l1b0k l1b0k commented Feb 19, 2025

No description provided.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 15.06073% with 1049 lines in your changes missing coverage. Please review.

Project coverage is 24.91%. Comparing base (99112f7) to head (4dc0211).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
pkg/aliyun/client/eflo_2.go 0.00% 234 Missing ⚠️
pkg/aliyun/client/ecs_2.go 0.00% 210 Missing ⚠️
pkg/aliyun/client/options.go 0.00% 138 Missing and 1 partial ⚠️
pkg/aliyun/client/eni.go 0.00% 70 Missing ⚠️
daemon/builder.go 0.00% 54 Missing ⚠️
pkg/aliyun/instance/ecs.go 0.00% 49 Missing ⚠️
pkg/controller/multi-ip/node/pool.go 55.23% 40 Missing and 7 partials ⚠️
pkg/aliyun/instance/eflo.go 26.22% 41 Missing and 4 partials ⚠️
pkg/eni/node_reconcile.go 57.89% 31 Missing and 9 partials ⚠️
pkg/aliyun/client/eflo.go 0.00% 38 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
- Coverage   26.41%   24.91%   -1.50%     
==========================================
  Files         121      124       +3     
  Lines       16116    17129    +1013     
==========================================
+ Hits         4257     4268      +11     
- Misses      11396    12401    +1005     
+ Partials      463      460       -3     
Flag Coverage Δ
unittests 24.91% <15.06%> (-1.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@l1b0k l1b0k force-pushed the eflo branch 8 times, most recently from 7cdf660 to 19a699b Compare February 21, 2025 07:43
- Modify the logic for retrieving instance metadata, optimizing with interfaces and caching
- Refactor the way EFLO instance metadata is retrieved
- Update relevant unit tests

Signed-off-by: l1b0k <[email protected]>
@BSWANG BSWANG merged commit 572ade7 into AliyunContainerService:main Feb 24, 2025
7 of 9 checks passed
@l1b0k l1b0k deleted the eflo branch February 24, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants