Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor plugin details modal using Vue (matomo-org#22055)
* Add translations * Pass 'has some admin access' down to components * Allow CTA container to optionally only display relevant actions (and not notifications or links) * Pass number of users down to view components * Reimplement plugin details modal in Vue * Use MissingReqsNotice component directly * Remove crypto dependency as simpler mechanism can be used * Add target blank to content links * Fix getting latest version mechanism to prevent tabs breaking Incorrect use of pop removed the last version from the list and it was not available for subsequent use. * Use root reference when filtering for matching elements inside setTimeout callback * Add types * Hide More details button from plugin CTA when displayed in modal Remove showActionsOnly flag and replace it with inModal flag as PO agreed to display the same actions in the modal as on the plugin card, except the More details button which would open the modal so it wouldn't make sense to display that. * Implement plugin details modal redesign * Make links from URLs and emails in the extra support information * Remove unused computed property * Fix license spelling in variable and method names * Remove number of users from Marketplace as product variant selection for free trials is automatic in the backend * Add email validity check to author information section * Rearrange code to remove some of the max line length lint exceptions * Move component state definition to the component file * Unify email sanitisation for author and supporting metadata * Add types for iframeResizer * Merge HelpLink and MoreDetailsButton components into MoreDetailsAction Both components were doing the same thing in a different form of a link (text vs button), so these got merged with props to control the button block look and the label. * Adjust action links within CTA container to only appear when not presented in a modal * Improve responsive behaviour on smaller screens * Ensure there's no empty text in CTA link actions * Update dist files * Remove "min-height" to prevent huge modals on huge screens * Update selectors for marketplace UI modal tests * Keep minimal UI tests for old modal * Update expected screenshots --------- Co-authored-by: Marc Neudert <[email protected]>
- Loading branch information