Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-536] Clean selection model #1835

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Separated selection model with precise options from selection model with remote data-based options

Changes made to the database:

  • N/A

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 175 lines in your changes missing coverage. Please review.

Project coverage is 44.54%. Comparing base (4b629d2) to head (e9407a6).

Files with missing lines Patch % Lines
...common/selection/FilterableRemoteSelectionModel.js 0.00% 52 Missing ⚠️
...nts/common/selection/dropdown/selectionDropdown.js 0.00% 24 Missing ⚠️
...blic/components/common/selection/SelectionModel.js 0.00% 20 Missing ⚠️
...ic/components/common/selection/selectionOptions.js 0.00% 16 Missing ⚠️
...ublic/components/common/selection/picker/picker.js 0.00% 9 Missing ⚠️
...lags/GaqFlags/gaqDetectorsSelectionModalTrigger.js 0.00% 8 Missing ⚠️
lib/public/views/Logs/Create/LogReplyModel.js 0.00% 7 Missing ⚠️
...lic/views/Logs/Create/TemplatedLogCreationModel.js 0.00% 7 Missing ⚠️
...ponents/common/selection/picker/pickerSelection.js 0.00% 6 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 6 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1835      +/-   ##
==========================================
- Coverage   44.57%   44.54%   -0.04%     
==========================================
  Files        1010     1008       -2     
  Lines       16959    16905      -54     
  Branches     3046     3017      -29     
==========================================
- Hits         7560     7530      -30     
+ Misses       9399     9375      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais martinboulais marked this pull request as draft January 29, 2025 11:20
@martinboulais martinboulais changed the title [O2B-532] Clean selection model [O2B-536] Clean selection model Jan 29, 2025
@martinboulais martinboulais force-pushed the mboulais/clean-selection-model branch 2 times, most recently from 4487255 to 7710b4c Compare February 5, 2025 15:44
@martinboulais martinboulais force-pushed the mboulais/clean-selection-model branch from 7710b4c to 68bdf91 Compare February 13, 2025 12:42
@martinboulais martinboulais force-pushed the mboulais/clean-selection-model branch 5 times, most recently from acdbe39 to 87b766b Compare February 14, 2025 13:00
- Separate selection model with precise options from selection model with remote data-based options

Fix linter

Cleaning

Factorize checkboxes/radio display

Fix after rebase
@martinboulais martinboulais force-pushed the mboulais/clean-selection-model branch from 87b766b to e9407a6 Compare February 14, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant