OPSEXP-2950 Prepare to update to Elasticsearch 8 by switching to the bitnami/elasticsearch chart #1267
+255
−206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxgomz
requested changes
Dec 19, 2024
helm/alfresco-content-services/templates/config-infrastructure.yaml
Outdated
Show resolved
Hide resolved
helm/alfresco-content-services/templates/config-infrastructure.yaml
Outdated
Show resolved
Hide resolved
alxgomz
requested changes
Dec 20, 2024
| configuration: | ||
| server: | ||
| basePath: "/kibana" | ||
| publicBaseUrl: "http://localhost/kibana" |
There was a problem hiding this comment.
I'm not sure what this value does but it looks suspicious. Did you check in integration pipeline kibana works ok?
There was a problem hiding this comment.
in global.known_urls we assume default deployment target localhost, so at least is consistent
just add more inline docs to make it easy to understand that it must be set for other types of deployment
pmacius
changed the title
pmacius
requested review from
gionn and
alxgomz
and removed request for
alxgomz
gionn
reviewed
Jan 8, 2025
| replicaCount: 0 | ||
| ingest: | ||
| replicaCount: 0 | ||
| kibana: |
There was a problem hiding this comment.
this kibana supports any authentication?
alxgomz
reviewed
Jan 8, 2025
Comment on lines
+6
to
+11
| {{- if .enabled}} | ||
| {{- $aasCtx := dict "Values" . "Chart" $.Chart "Release" $.Release }} | ||
| {{- $aasServiceName := include "alfresco-audit-storage.fullname" $aasCtx }} | ||
| {{- $aasServicePort := .service.port | toString }} | ||
| {{- printf "http://%s:%s" $aasServiceName $aasServicePort }} | ||
| {{- end }} |
There was a problem hiding this comment.
cosmetics
Suggested change
| {{- if .enabled}} | |
| {{- $aasCtx := dict "Values" . "Chart" $.Chart "Release" $.Release }} | |
| {{- $aasServiceName := include "alfresco-audit-storage.fullname" $aasCtx }} | |
| {{- $aasServicePort := .service.port | toString }} | |
| {{- printf "http://%s:%s" $aasServiceName $aasServicePort }} | |
| {{- end }} | |
| {{- if .enabled }} | |
| {{- $aasCtx := dict "Values" . "Chart" $.Chart "Release" $.Release }} | |
| {{- $aasServiceName := include "alfresco-audit-storage.fullname" $aasCtx }} | |
| {{- $aasServicePort := .service.port | toString }} | |
| {{- printf "http://%s:%s" $aasServiceName $aasServicePort }} | |
| {{- end }} |
Comment on lines
+30
to
+54
|
|
||
| {{/* | ||
| Compute the url for elasticsearch for audit | ||
|
|
||
| Usage: include "alfresco-content-services.audit.elasticsearchUrl" $ | ||
|
|
||
| */}} | ||
| {{- define "alfresco-content-services.audit.elasticsearchUrl" -}} | ||
| {{- $elasticsearch_audit_url := "" }} | ||
| {{- if .Values.global.auditIndex.url }} | ||
| {{- $elasticsearch_audit_url = .Values.global.auditIndex.url }} | ||
| {{- else }} | ||
| {{- with (index .Values "elasticsearch") }} | ||
| {{- if .enabled }} | ||
| {{- $auditEsHost := printf "%s-%s" $.Release.Name (($.Values.global.elasticsearch).service.name | default "elasticsearch") }} | ||
| {{- $auditEsPort := ($.Values.global.elasticsearch).service.ports.restApi | default 9200 }} | ||
| {{- $auditEsProto := .protocol | default "http" }} | ||
| {{- $elasticsearch_audit_url = coalesce $.Values.global.auditIndex.url (printf "%s://%s:%v" $auditEsProto $auditEsHost $auditEsPort) }} | ||
| {{- else if index $.Values "alfresco-audit-storage" "enabled" }} | ||
| {{- fail "Chart is configured to use Alfresco Audit Storage but no index backend has been provided. Set one using either global.auditIndex.url or elasticsearch.enabled" }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- end }} | ||
| {{- print $elasticsearch_audit_url }} | ||
| {{- end -}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: OPSEXP-2950