Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better? mileage compute #120

Closed
wants to merge 2 commits into from
Closed

Conversation

Goloso98
Copy link

@Goloso98 Goloso98 commented Oct 6, 2024

Mileage was computed relative on two adjacent fillups.
This provides mileage from tank full to tank full (if no missed fillup happened)
Only for L/100Km, just because I was not sure if was going to break other stuff.

@Goloso98 Goloso98 changed the title Merge mileagesplits onto master Better? mileage compute Oct 6, 2024
@AlfHou
Copy link
Owner

AlfHou commented Nov 3, 2024

Hi! Sorry, I never received notification about this PR. I will review with ASAP (might take a couple of days). Thanjk you for contributing :)

@Goloso98
Copy link
Author

Goloso98 commented Nov 8, 2024

Hey, nice to ear.
I mishappen and included a quick fix for viewing mileage on mobile "ui/src/router/views/vehicle.vue" as a table, since the graph was always messed up, be aware of that.
Thanks for your reply!

@AlfHou
Copy link
Owner

AlfHou commented Nov 11, 2024

If I understand you correctly, the changes in vehicle.vue and mileageTable.vue are not meant to be included in the PR? Or am I misunderstanding?

@Goloso98
Copy link
Author

Since this is messy, i have oppened a new pr #123 , and im clossing this one.
(didnt know any better to remove the unwanted commit)

@Goloso98 Goloso98 closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants