This repository has been archived by the owner on Mar 9, 2018. It is now read-only.
A few changes to improve compatibility #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihla
added a commit
to ihla/UIBubbleTableView
that referenced
this pull request
May 14, 2014
…e on orientation change” - merged with pull request AlexBarinov#65 “A few changes to improve compatibility” - improved performance (partly) by image caching for static images, NSBubbleData images not cached yet!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few places where the return type defined in the interface did not match the locally typed variable. In this pull request I changed to local variable to match the interface type or fixed places where the TabeView delegate type did not match the overriding method type.
Example:
Apple defines as - (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath but src/UIBubbleTableView.m had it as "float"
see: https://developer.apple.com/library/ios/documentation/UIKit/Reference/UITableViewDelegate_Protocol/Reference/Reference.html#//apple_ref/occ/intfm/UITableViewDelegate/tableView:heightForRowAtIndexPath: