Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add import-deno as crate feature to import using .ts extension #376

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eythaann
Copy link

Goal

Allow to generate files compatible with Deno projects.

Changes

I added a new feature import-deno works identically as import-esm but instead of import using .js Deno uses .ts

Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

Copy link
Collaborator

@gustavo-shigueo gustavo-shigueo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --all-features test is failing due to the trim_end_matches problem mentioned above

@eythaann
Copy link
Author

Fixed, just to note, I'm not able to run npx tsc like there's no package.json on the project.

Copy link
Collaborator

@gustavo-shigueo gustavo-shigueo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! @NyxCode is there anything you'd like to add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants