Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include borrowed types' type arguments in typescript #181

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

aatukaj
Copy link
Contributor

@aatukaj aatukaj commented Dec 10, 2023

Borrowed types' type arguments weren't previously being included in the typescript export.
e.g.

struct A<'a> {
    b: &'a Vec<usize>,
}

Would be exported as:

interface A { b: Array, }

With this pr it's exported correctly as:

interface A { b: Array<number>, }

@NyxCode
Copy link
Collaborator

NyxCode commented Dec 12, 2023

Thanks for the PR!

@NyxCode NyxCode merged commit 0fb6094 into Aleph-Alpha:main Dec 12, 2023
1 check passed
escritorio-gustavo added a commit that referenced this pull request Jan 26, 2024
This was fixed in #128 and improved upon in #181 and #199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants