-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a manual SingleFileExporter #100
Conversation
Allows manually exporting a set of types to a single file.
I like this. Thank you. |
Any feedback on this? ps: @Mattchine it seems to work fine with |
Happy to help wherever needed get this merged, assuming it is within the scope of the project? Single file exporting (e.g. index.ts) is something I personally would really like to see, but understand if it isn't something the maintainer wants 🙂 |
I'm also missing this feature - I hacked my way out to do the same thing in a custom build.rs, but it would be way better to have this feature merged/available. |
Updated tests to expect |
@NyxCode I'm not familiar with this part of the codebase, I think you should have a look |
|
||
/// Finalize the export. | ||
/// | ||
/// Returns the generated typescritp code on success, or an error if any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in "typescript"
let buffer = if with_codegen_warning { | ||
NOTE.to_string() | ||
} else { | ||
String::new() | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NyxCode should the codegen warning be optional?
It was supposed to be a "comment" review, not "approval"
Apart from me cleaning up merge conflicts, this has been stale for over a year now, so I'll be closing this issue |
Allows manually exporting a set of types to a single file.