Allow Rails 7.2 #2998
Closed
Allow Rails 7.2 #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2998 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 233 233
Lines 6308 6308
=======================================
Hits 6084 6084
Misses 224 224 ☔ View full report in Codecov by Sentry. |
and drop builds for Ruby 3.0
Remove me after new release of awesome_nested_set
Chrome 128 introduced a new search engine selection. By using the Rails' headless_chrome setup and disabling the feature it works with newer versions of chrome.
tvdeyen
force-pushed
the
tvdeyen-patch-1
branch
from
6b0638c to
a91dabb
Compare
This is the version for Rails >= 6.1
Passing options to render instead of stubbing the view object fixes issues with Rails 7.2
In Rails 7.2 the to_s monkey patch has been removed. Using to_fs instead.
Using nil as default format for I18n does not work in Rails 7.2 anymore.
|
closed in favor of #2999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Needs
Notable changes (remove if none)
Explain any changes (maybe breaking?) that have been made.
Screenshots
Remove if no visual changes have been made.
Checklist