Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: escape principal and resource tag value in authorizer metrics #227

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

biggusdonzus
Copy link
Contributor

@biggusdonzus biggusdonzus commented Jan 10, 2025

Escape commas, spaces and equals because in the exported JMX metrics to avoid parsing errors.

@biggusdonzus biggusdonzus changed the title fix: escape principal and resource tag value in authorizer metrics Fix: escape principal and resource tag value in authorizer metrics Jan 10, 2025
@biggusdonzus biggusdonzus force-pushed the fdorlandi-fix-escape-metric-tags branch from 06cb7b1 to 058d47a Compare January 13, 2025 08:12
@biggusdonzus biggusdonzus marked this pull request as ready for review January 13, 2025 08:22
@biggusdonzus biggusdonzus requested review from a team as code owners January 13, 2025 08:22
@biggusdonzus biggusdonzus requested a review from tvainika January 13, 2025 08:22
@tvainika tvainika merged commit 5eb9cb4 into main Jan 13, 2025
4 checks passed
@tvainika tvainika deleted the fdorlandi-fix-escape-metric-tags branch January 13, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants