repomap.get_tags_raw doesn't crash on UTF-16 files #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to Aider-AI#305, Aider would crash while building a repomap when attempting to load a file with non UTF-16 content. This commit adds a try/except block that returns nothing back to the caller, allowing repomap to skip the file and continue. Future considerations might be to use the read_file function in `io.py` I've not run any tests other than ensuring that `/tokens` does not crash when a non UTF-8 file is present in the Git repo.
|
Thanks for the PR. I took your suggestion and fixed this issue using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #305, Aider would crash while building a repomap when attempting to load a file with non UTF-16 content. This commit adds a try/except block that returns nothing back to the caller, allowing repomap to skip the file and continue.
Future considerations might be to use the read_file function in
io.pyI've not run any tests other than ensuring that
/tokensdoes not crash when a non UTF-8 file is present in the Git repo.