boulder/draft: Default to autotools on unhandled build system #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joebonrichie
force-pushed
the
write-the-yaml-file-out-damnit
branch
from
bc3b5ba to
e411f51
Compare
This will most likely be the closest match, plus we write out the recipe file unconditionally then much to deangst to our packagers.
joebonrichie
force-pushed
the
write-the-yaml-file-out-damnit
branch
from
e411f51 to
36d095f
Compare
tarkah
reviewed
Jan 7, 2025
Comment on lines
+58
to
+64
| let build_system = build.detected_system.unwrap_or_else(|| { | ||
| println!( | ||
| "{} | Unhandled build system! - Defaulting to autotools", | ||
| "Warning".yellow() | ||
| ); | ||
| build::System::Autotools | ||
| }); |
There was a problem hiding this comment.
I see you're "logging" like this in a consistent format across various PRs.
We should really use log / some logging library like env_logger / fern / etc, and do this properly so they can be filtered out if need be. Then we can have some moss::logging module with some helpers to produce standardized log messages throughout the codebase
|
For now I'll merge as its definitely necessary and I can't blame lack of logging on anyone but me :D |
ikeycode
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will most likely be the closest match, plus we write out the recipe file unconditionally then much to deangst to our packagers.