-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fastlane Card Component signup #3043
Conversation
|
Size Change: +10.8 kB (+1.39%) Total Size: 788 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
I know you say we don't validate the mobile number - but it feels wrong that you can submit this PM whilst the field is visible, but clearly not filled |
Yea I agree. It is weird.. the main point for now is to not ruin the conversion if the shopper didn't enter the phone or entered the wrong phone.. |
packages/lib/src/components/Card/components/Fastlane/InfoModal.scss
Outdated
Show resolved
Hide resolved
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
Summary
This PR introduces the Fastlane UI inside the Card component.
How it works:
fastlaneConfiguration
objectSome highlights:
Link
component which we can use for hyperlinksstaticValue
to theField
component, so we can display static values (similar to how Bento does)fastlaneData
property, which is an encoded blob containing the data for the paymentThis flow can be tested through Storybook on the Fastlane stories.
Tests
Next PR's: