-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics: track api errors #3035
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longyulongyu
requested review from
pabloai,
sponglord,
m1aw and
ribeiroguilherme
as code owners
December 19, 2024 13:08
🦋 Changeset detectedLatest commit: f6c80e6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +738 B (+0.1%) Total Size: 770 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
ribeiroguilherme
approved these changes
Jan 2, 2025
- makePayments: '620' - submitPaymentDetails: '621' - submitThreeDS2Fingerprint: '622' - createOrder: '623'
longyulongyu
force-pushed
the
analytics-api-errors
branch
from
January 2, 2025 15:33
f83dd0f
to
f6c80e6
Compare
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/sessions/${session.id}/payments
/sessions/${session.id}/orders
/sessions/${session.id}/paymentDetails
v1/submitThreeDS2Fingerprint
NETWORK_ERROR
and send this specific error to the analytics.Tested scenarios
Added unit tests and manually tested sending error event for the
v1/submitThreeDS2Fingerprint
endpoint.Fixed issue: COWEB-1471