v6 - Adding isExpress flag for GooglePay and ApplePay #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Size Change: +266 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
size-limit report 📦
|
ribeiroguilherme
requested review from
marcperez,
pabloai,
sponglord,
m1aw and
longyulongyu
as code owners
ribeiroguilherme
changed the title
m1aw
approved these changes
Mar 14, 2024
|
asumaran
reviewed
Aug 21, 2024
Comment on lines
+68
to
+70
| test('should throw error when express callbacks are passed but isExpress flag is not set', () => { | ||
| expect(() => new GooglePay(global.core, { paymentDataCallbacks: { onPaymentDataChanged: jest.fn() } })).toThrow(); | ||
| }); |
There was a problem hiding this comment.
It would be great to see this documented somewhere. There's no mention about it on your documentation.
There was a problem hiding this comment.
Hi @asumaran - we do mention in the release notes, but indeed we are not mentioning it in the payment method page itself. I shared the feedback with the docs team. Thanks for flagging it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isExpressflag . This flag makes the component add thesubtype: 'express'to the payment data. This impacts the reports on CA, showing to merchants the payments that are being done using express flow.Tested scenarios