For zero auth payments, only store the payment method if the configuration says we should #2589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y if the configuration says we should
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 4cf1ff5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +181 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
longyulongyu
approved these changes
Mar 6, 2024
…d we are trying to store a card
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The fix in #2571 did not cover all use cases
For regular card, zero auth payments, we should store the payment method only if the configuration says we should:
storePaymentMethodMode: 'askForConsent'(which will lead to aconfiguration: {enableStoreDetails: true}object in the/sessions/setupresponse)enableStoreDetails: trueWhat we are doing is.. if for a normal payment we would show the "Save for my next payment" checkbox, for a zero-auth payment we effectively click the checkbox on behalf of the shopper, if we are allowed to.
To this end, in the
Cardcomponent I have created a new, separate propertyshowStoreDetailsCheckboxwhich is solely concerned with the UI and whether we should show the "Save for my next payment" checkbox.The original
enableStoreDetailsproperty is retained to store the original value from the configuration passed to the componentTested scenarios
New unit tests
All unit tests pass
Fixed issue: COWEB-1352