Fix/v6 mandatory country code with redirects #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
|
|
Size Change: +5 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
size-limit report 📦
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed issue with mandatory
countryCode,/sessionsand redirects. For sessions you only ever have to specifycountryCodethe first time you initialise CheckoutThe only issue is with the manual, non-sessions flow - if you handle the redirect by making a new instance of Checkout, instead of just making a
/detailscall, then you have to specify thecountryCode. This is how our playground example currently works.Tested scenarios
Redirect in /sessions does not generate a "missing countryCode" error
Relates to issue: #2540