v6 All UIElements can receive defaultProps based on regulations #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
|
size-limit report 📦
|
|
Size Change: +2.01 kB (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
sponglord
changed the title
…ed on whether component is a Dropin or not
ribeiroguilherme
approved these changes
Feb 16, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Finnish regulations state that no payment methods can be open by default...
This PR allows all
UIElementsto receive a set ofdefaultPropsbased on regulatory requirements (currently retrieved based oncountryCode)The functionality is now in place should this logic ever need to be expanded (based on other country's requirements &/or different logic entirely)
It should be noted that the merchant can still override these regulatory defaults if they want to. That's up to them.
But at least CheckoutWeb will be compliant "out of the box"
Tested scenarios
All current unit tests pass
Add new ones specific to this rule
Relates to issue: COAPI-293