Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping sf version to 4.8.0 #2488

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Bumping sf version to 4.8.0 #2488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b06621f
Bumping sf version to 4.8.0
sponglord Dec 11, 2023
f7bb0ed
Adding changeset file
sponglord Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/light-pianos-join.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@adyen/adyen-web': minor
---

Bumping sf version to 4.8.0 which includes a more comprehensive startup log (to help with debugging)
2 changes: 1 addition & 1 deletion packages/e2e/tests/cards/errorPanel/errorPanel.avsCard.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ test('#1 avsCard error fields and inputs should have correct aria attributes', a
await t.switchToMainWindow().switchToIframe(cardPage.iframeSelector.nth(0));
const adb = await getInputSelector('encryptedCardNumber', true).getAttribute('aria-describedby');
await t.expect(adb).contains('adyen-checkout-encryptedCardNumber-');
await t.expect(adb).contains('-ariaError');
await t.expect(adb).contains('-ariaContext');
await t.switchToMainWindow();

// Address input's error field should have correct aria attrs
Expand Down
3 changes: 2 additions & 1 deletion packages/e2e/tests/utils/commonUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const getInputSelector = (fieldType, withSelector = false) => {
};

export const getAriaErrorField = (fieldType, withSelector = false) => {
const selStr = `#${fieldType}-ariaError`;
const selStr = `#${fieldType}-ariaContext`;
return withSelector ? Selector(selStr) : selStr;
};

Expand Down Expand Up @@ -68,6 +68,7 @@ export const deleteDigitsFromIFrame = async (t, iframeSelector, iFrameNum, iFram
};

export const checkIframeInputContainsValue = async (t, iframeSelector, iFrameNum, iFrameInputSelector, valueToCheck) => {
// prettier-ignore
return t
.switchToMainWindow()
.switchToIframe(iframeSelector.nth(iFrameNum))
Expand Down
2 changes: 1 addition & 1 deletion packages/lib/src/components/internal/SecuredFields/lib/configuration/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const ENCRYPTED_SECURITY_CODE_4_DIGITS = 'encryptedSecurityCode4digits';

export const GIFT_CARD = 'giftcard';

export const SF_VERSION = '4.5.1';
export const SF_VERSION = '4.8.0';

export const DEFAULT_CARD_GROUP_TYPES = ['amex', 'mc', 'visa'];

Expand Down