Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting paymentMethodConfiguration type to support txVariants not mapped internally #2349

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

ribeiroguilherme
Copy link
Contributor

Summary

paymentMethodConfiguration typescript definition does not support tx variants that are not mapped internally. If they are set, the linter will complain. This PR fixes this problem.

Tested scenarios

  • Checked that following code does not trigger TS complains:
 paymentMethodsConfiguration: {
    directEbanking: {
        name: 'Sofort Klarna'
    },
}

Fixed issue: #2320

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023

🦋 Changeset detected

Latest commit: d92e226

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adyen/adyen-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Size Change: +10.6 kB (+1%)

Total Size: 1.08 MB

Filename Size Change
packages/lib/dist/adyen.js 286 kB +2.5 kB (+1%)
packages/lib/dist/cjs/index.js 247 kB +2.59 kB (+1%)
packages/lib/dist/es.modern/ar.js 6.54 kB +122 B (+2%)
packages/lib/dist/es.modern/cs-CZ.js 5.81 kB +17 B (0%)
packages/lib/dist/es.modern/da-DK.js 5.29 kB +19 B (0%)
packages/lib/dist/es.modern/de-DE.js 5.7 kB +39 B (+1%)
packages/lib/dist/es.modern/el-GR.js 7.44 kB +148 B (+2%)
packages/lib/dist/es.modern/es-ES.js 5.37 kB +9 B (0%)
packages/lib/dist/es.modern/fi-FI.js 5.38 kB +28 B (+1%)
packages/lib/dist/es.modern/fr-FR.js 5.56 kB +91 B (+2%)
packages/lib/dist/es.modern/hr-HR.js 5.61 kB +113 B (+2%)
packages/lib/dist/es.modern/hu-HU.js 5.86 kB +82 B (+1%)
packages/lib/dist/es.modern/index.js 119 kB +644 B (+1%)
packages/lib/dist/es.modern/it-IT.js 5.44 kB +101 B (+2%)
packages/lib/dist/es.modern/ja-JP.js 6.27 kB +91 B (+1%)
packages/lib/dist/es.modern/ko-KR.js 5.91 kB +126 B (+2%)
packages/lib/dist/es.modern/nl-NL.js 5.4 kB +31 B (+1%)
packages/lib/dist/es.modern/no-NO.js 5.27 kB +17 B (0%)
packages/lib/dist/es.modern/pl-PL.js 5.87 kB +110 B (+2%)
packages/lib/dist/es.modern/pt-BR.js 5.43 kB +107 B (+2%)
packages/lib/dist/es.modern/pt-PT.js 5.55 kB +99 B (+2%)
packages/lib/dist/es.modern/ro-RO.js 5.68 kB +109 B (+2%)
packages/lib/dist/es.modern/ru-RU.js 6.89 kB +133 B (+2%)
packages/lib/dist/es.modern/sk-SK.js 5.97 kB +122 B (+2%)
packages/lib/dist/es.modern/sl-SI.js 5.52 kB +88 B (+2%)
packages/lib/dist/es.modern/sv-SE.js 5.23 kB +4 B (0%)
packages/lib/dist/es.modern/zh-CN.js 5.72 kB +100 B (+2%)
packages/lib/dist/es.modern/zh-TW.js 5.86 kB +120 B (+2%)
packages/lib/dist/es/ar.js 6.54 kB +122 B (+2%)
packages/lib/dist/es/cs-CZ.js 5.81 kB +17 B (0%)
packages/lib/dist/es/da-DK.js 5.29 kB +19 B (0%)
packages/lib/dist/es/de-DE.js 5.7 kB +39 B (+1%)
packages/lib/dist/es/el-GR.js 7.44 kB +148 B (+2%)
packages/lib/dist/es/es-ES.js 5.37 kB +9 B (0%)
packages/lib/dist/es/fi-FI.js 5.38 kB +28 B (+1%)
packages/lib/dist/es/fr-FR.js 5.56 kB +91 B (+2%)
packages/lib/dist/es/hr-HR.js 5.61 kB +113 B (+2%)
packages/lib/dist/es/hu-HU.js 5.86 kB +82 B (+1%)
packages/lib/dist/es/index.js 139 kB +828 B (+1%)
packages/lib/dist/es/it-IT.js 5.44 kB +101 B (+2%)
packages/lib/dist/es/ja-JP.js 6.27 kB +91 B (+1%)
packages/lib/dist/es/ko-KR.js 5.91 kB +126 B (+2%)
packages/lib/dist/es/nl-NL.js 5.4 kB +31 B (+1%)
packages/lib/dist/es/no-NO.js 5.27 kB +17 B (0%)
packages/lib/dist/es/pl-PL.js 5.87 kB +110 B (+2%)
packages/lib/dist/es/pt-BR.js 5.43 kB +107 B (+2%)
packages/lib/dist/es/pt-PT.js 5.55 kB +99 B (+2%)
packages/lib/dist/es/ro-RO.js 5.68 kB +109 B (+2%)
packages/lib/dist/es/ru-RU.js 6.89 kB +133 B (+2%)
packages/lib/dist/es/sk-SK.js 5.97 kB +122 B (+2%)
packages/lib/dist/es/sl-SI.js 5.52 kB +88 B (+2%)
packages/lib/dist/es/sv-SE.js 5.23 kB +4 B (0%)
packages/lib/dist/es/zh-CN.js 5.72 kB +100 B (+2%)
packages/lib/dist/es/zh-TW.js 5.86 kB +120 B (+2%)

compressed-size-action

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ribeiroguilherme ribeiroguilherme merged commit 4f3fedf into main Oct 16, 2023
10 checks passed
@ribeiroguilherme ribeiroguilherme deleted the fix/enabling-config-for-txvariants-not-mapped branch October 16, 2023 14:14
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants