Feature/using checkoutanalytics #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
|
Size Change: +12.3 kB (+1%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
Feature/using checkoutanalytics mvp
…ssue in CustomCard)
* Add 3DS2 analytics events for data sent & iframe loaded. Plus error event when paymentData missing in 3DS2 * Using UIElement.submitAnalytics for 3DS2 * Fixed clause (had been changed to test error) * Move app specific analytics logic to a separate "processing" function. This separates concerns and makes testing easier * core.ts uses sendAnalytics function * Comments added regarding what properties are added to what analytics objects * Redeclare BaseElement.this._node *before* we render (was causing an issue in CustomCard) * Card has onConfigSuccess function to send analytics info event (type="configured") when SFS have all configured * Adding analytics logs for when 3DS2 fingerprint or challenge complete * Also pass isStoredPaymentMethod and brand with "configured" analytics events for storedCards * Added unit tests for Card & GooglePay testing the shape of the analytics objects they generate * Added unit tests for 3DS2 errors - testing the shape of the analytics objects they generate * Fixing type * Jumping through hoops for sonarcloud * Jumping through hoops for sonarcloud * Removing console.log * Specifying type. Move card related, "is it a stored card" logic, out of UIElement * Fixing linting * Fixing linting, tightening up onSubmitAnalytics type * After SDKs meeting: removing target prop from "submit" log events * Added "focus" & "unfocus" info events to Custom Card comp
* Adding selected info event for issuerList buttons * IssuerList handles analytics for both dropdown & issuerList buttons * Detect and send analytics event when issuerList's dropdown is expanded * Detect and send analytics event (debounced) when issuerList search functionality is used * Moved debounce function to own util file * Fixes for unit tests * Made debounce for search a constant * Adding new unit tests * Removing child comp's submitAnalytics function (since all it does is call super). Removing unused param.
* Detect and send analytics event when qrCode's "Copy" btn is pressed * Fixing unit test fail * Removing child comp's submitAnalytics function (since all it does is call super)
# Conflicts: # packages/lib/src/core/core.ts
…koutAttemptId call failing
# Conflicts: # packages/lib/tsconfig.json
…s how analytics events are created
* Mapping validation error codes to those expected by the endpoint * Fixing unit tests
* Extending branch feature_using_checkoutanalytics to add 3DS2 analytic-actions (for data sent & iframe loaded) * commenting out console logs * Extending branch feature_using_checkoutanalytics_with_3DS2_events to add base64 refactor code (more errors detected in decode process) * Changing analytics terminology - generic term is events with specific types being: info, log, error * Changing analytics terminology - generic term is events with specific types being: info, log, error * Fixing unit tests * Fixing unit tests * Fixed unit test * Adding util to determine if base64 decoding has lead to an error object. Tightened up types * Changing message for actionHandled when challenge iframe loaded
… what the rules are within securedFields
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating Analytics functionality to work against the new
/checkoutanalyticsendpointThis involves:
checkoutAttemptIdand send in initial analytics details (channel,flavor,localeetc)onSubmitis called (indicating a "Pay" button press)createFromActionis called (indicating a/paymentsresponse mandating an "action")Tested scenarios
New unit tests added
Relates to issue: COAPI-6