Fixing Sonarcloud complains about ApplePayService (#2846)

* sonarcloud reliability issues fix * changeset
Adyen · Sep 11, 2024 · ae665f0 · ae665f0
1 parent 08102bd
commit ae665f0
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 8 deletions.
diff --git a/.changeset/tough-carrots-jog.md b/.changeset/tough-carrots-jog.md
@@ -0,0 +1,5 @@
+---
+'@adyen/adyen-web': patch
+---
+
+Fixing reliability Sonarcloud issues related to ApplePayService
diff --git a/packages/lib/src/components/ApplePay/ApplePayService.ts b/packages/lib/src/components/ApplePay/ApplePayService.ts
@@ -23,23 +23,34 @@ class ApplePayService {
         this.options = options;
 
         this.session = new ApplePaySession(options.version, paymentRequest);
-        /* eslint-disable @typescript-eslint/no-misused-promises */
-        this.session.onvalidatemerchant = event => this.onvalidatemerchant(event, options.onValidateMerchant);
-        this.session.onpaymentauthorized = event => this.onpaymentauthorized(event, options.onPaymentAuthorized);
-        this.session.oncancel = event => this.oncancel(event, options.onCancel);
+        this.session.onvalidatemerchant = event => {
+            void this.onvalidatemerchant(event, options.onValidateMerchant);
+        };
+        this.session.onpaymentauthorized = event => {
+            void this.onpaymentauthorized(event, options.onPaymentAuthorized);
+        };
+
+        this.session.oncancel = event => {
+            this.oncancel(event, options.onCancel);
+        };
 
         if (typeof options.onPaymentMethodSelected === 'function') {
-            this.session.onpaymentmethodselected = event => this.onpaymentmethodselected(event, options.onPaymentMethodSelected);
+            this.session.onpaymentmethodselected = event => {
+                void this.onpaymentmethodselected(event, options.onPaymentMethodSelected);
+            };
         }
 
         if (typeof options.onShippingContactSelected === 'function') {
-            this.session.onshippingcontactselected = event => this.onshippingcontactselected(event, options.onShippingContactSelected);
+            this.session.onshippingcontactselected = event => {
+                void this.onshippingcontactselected(event, options.onShippingContactSelected);
+            };
         }
 
         if (typeof options.onShippingMethodSelected === 'function') {
-            this.session.onshippingmethodselected = event => this.onshippingmethodselected(event, options.onShippingMethodSelected);
+            this.session.onshippingmethodselected = event => {
+                void this.onshippingmethodselected(event, options.onShippingMethodSelected);
+            };
         }
-        /* eslint-enable @typescript-eslint/no-misused-promises */
     }
 
     /**