Mary Morrison #26
Open
Mary Morrison #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… returns the total score value for the given word, and adds 50 pts if word is 7 letters
…akes an array of words and scores them then outputs the winning word, also handles ties and 7 letter bonus situations
| score: function(word) { | ||
| var string = word.toUpperCase(), | ||
| score = 0; | ||
| for(var i=0; i < string.length; i) { |
There was a problem hiding this comment.
I'm not sure if this will work without i++
| score = Scrabble.scoreChart[string[i]]; | ||
| } | ||
| if (string.length === 7) { | ||
| score = 50; |
There was a problem hiding this comment.
I believe this logic should be +50, as opposed to =50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finished wave 1, did part of wave 2. Translating our old project from ruby to javascript went pretty well. I like it....for now. Would have liked to finish wave 2, but went to a VR event last night and a negotiating $$ event earlier this week, so, yeah. I couldn't figure out the syntax to make the score chart an object with numbers as properties and an array of letters as their values. Need more frequent commits for next project!