Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leah Bueing - JS Scrabble #21

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Leah Bueing - JS Scrabble #21

wants to merge 3 commits into from

Conversation

lbueing
Copy link

@lbueing lbueing commented Nov 18, 2016

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nicely done!

max = scoreWord(val);
maxWord = val;
} else if ( scoreWord(val) == max && (scoreWord(val).length < maxWord.length || scoreWord(val).length == 7 && maxWord.length < 7 )) {
max = scoreWord(val);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done here!

var array = ['jar', 'cookie', 'marshie', 'tool', 'zzz'];
console.log(highestScoreFrom(array));


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably should have several permutations of the possible list of words to do adequate testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants