Beyoncy - Rachel, Lauren, Joanna, and Alyssa #39

alyssahursh · 2016-10-28T22:31:39Z

@CheezItMan
Rachel, Lauren, Joanna, and Alyssa

Copied from beyoncy

alyssahursh · 2016-10-28T22:35:05Z

This is a copy of our original repository, which is here. We'd recommend checking that repository instead.

See Beyoncy on Heroku.

rpavilanis · 2016-10-28T22:54:45Z

How did your team work together?

Organization: Our team initially made a list of all of our user stories, and separated them out by customer, guest, and admin on our Trello Boards. We also made separate ERDs and then came together and compared, before incorporating feedback into a final ERD. I think this was really helpful because it allowed all of us to think through the model relationships and as a result, we all had a stronger overall idea of the project conceptualization before starting work on it. On Trello, we also made a board for each of us, and we dragged user stories and other tasks over to it as we were working on them, and after they were completed, we moved them to a complete column. I think that after the first week, we all started using the Trello more regularly, and this helped a lot with seeing how far we had yet to go. I think that regular stand-ups and communication, along with regular PRs (describing what we did and showing code and localhost project) also helped. I feel like this became more solid after the first week. I really appreciate that Lauren took the time to put together an "end-of-project" plan on Wednesday of the second week, which helped us see how much time we had to work (and what we were working), when we were planning to push to Heroku again, and also allotted time for two presentation practice sessions.
What I might do differently next time: I think after the first week, we all realized we had some room for improvement in terms of organization, leadership, and communication, and as a result we changed things (frequency of using Trello boards, people taking more leadership and ownership, reviewing commits/PRs with each other, and more frequent communication/check-ins (at least it felt like that to me)). I think that next time, it might be helpful to take more time determining project areas of focus for each person before jumping in. Again, we narrowed this focus in week two, but it would have been nice to know this more specifically going into Week 1 of the project (e.g., Joanna doing testing, Lauren doing OAuth/Admin stuff, etc.).
To C7: I think all doing your own ERD before coming to talk about it and jumping into the project was so helpful, so I would recommend that. Use your Trello Board! Communicate regularly. Okay, so that was more than one...just know you will get through it! :) Breathe!

TECHNICAL

What went well: Personally, I was really happy that I pushed myself on a couple of things that I wasn't sure I could do (mainly because we hadn't tried them in class), and then got them working. Specifically, I was proud of my work on the search bar, lemons for reviews, dropdowns, and image gem (even though it didn't end up in the final project because it only worked locally). I feel like I became more comfortable with merge conflicts over the week as well. I also feel more confident overall in approaching a project from the very beginning, without as much direction. In the end, I also feel a lot better about collaborating with a team around completing a big project like this.
What was most challenging?: I think it is hard to not touch every aspect of a project. I didn't do anything with the shopping cart, and I still don't have a strong understanding of how I would do one. I did really appreciate that we all had to figure out OAuth with our Task Lists, because even though completing that was stressful while also doing Beyoncy, I felt like I still had that experience even though Lauren and Joanna tackled most of that on Beyoncy. It was also tricky to have four hands touching the code, because we all have slightly different styles and I tend to worry that I am going to mess something up or do something in a way that won't be what others would want. I think that generally this worked out okay though - I think I tend to be too hard on myself or not give myself enough credit for things...something that I am working on improving. I definitely feel as though our code wasn't as clean or organized as it could be, and I think that on individual projects, it is easier to do this because you can go back in and update/change things as you want to improve. This code base got pretty large, so it wasn't as simple to do that, because changing one thing can effect other things.

Overall, I feel so proud of my team and I am excited with the final project. There is always room to improve, but I think with the time we had, we rocked it. :)

CheezItMan

@rpavilanis @alyssahursh @laurenfb @jm-rives

I've added an overall view in your progress reports document, but I have specific code-related comments here, so you can see what I'm talking about specifically.

Overall well done. Looks like some more work needed to be done with testing, styling and some work with controllers, but overall very nice.

CheezItMan · 2016-10-30T04:28:52Z

app/controllers/order_products_controller.rb

+
+    already_in = false
+
+    @order.order_products.each do |order_product|


You can work around the need for this if statement by doing an:

Order_Product.where(order_id: @order.id).where(product_id: params[:order_products][:id].to_i)

CheezItMan · 2016-10-30T21:53:27Z

app/views/shared/_flash_notice.html.erb

@@ -0,0 +1,4 @@
+<% if flash[:notice] %>
+  <%= flash[:notice] %>
+  <% flash[:notice] = nil %>


I realize I'd shown the <% flash[:notice] = nil %>, but it's not needed. You can just display the flash notice and it'll be gone in the next page load.

Good use of a partial though, although you might consider some formatting.

CheezItMan · 2016-11-07T03:16:48Z

app/views/layouts/application.html.erb

+  <body>
+    <header>
+      <nav>
+        <ul class="vertical menu medium-horizontal" data-responsive-menu="accordion medium-dropdown">


Nice work using responsive menus. Some more work needs to be done on backgrounds to the top-bar when it gets to smaller screen sizes.

CheezItMan · 2016-11-07T03:17:48Z

app/views/orders/_list.html.erb

@@ -0,0 +1,16 @@
+<table>


Good use of partials

CheezItMan · 2016-11-07T03:18:37Z

test/helpers/application_helper_test.rb

@@ -0,0 +1,46 @@
+require 'test_helper'


Very nice work putting in tests for the view helpers.

CheezItMan · 2016-11-07T03:59:00Z

app/controllers/application_controller.rb

@@ -2,4 +2,11 @@ class ApplicationController < ActionController::Base
  # Prevent CSRF attacks by raising an exception.
  # For APIs, you may want to use :null_session instead.
  protect_from_forgery with: :exception
+
+  before_filter :set_categories
+


Do you want to load the categories on each page? This will always run.

CheezItMan · 2016-11-07T04:00:06Z

app/controllers/categories_controller.rb

+
+  private
+  def find_category
+    @category = Category.find(params[:id])


find will actually throw an Error if the method fails, so the if @category.nil? will never execute. If you want to do this you should use Category.find_by instead.

CheezItMan · 2016-11-07T04:01:33Z

app/controllers/order_products_controller.rb

+      if order_product.product_id.to_i == params[:order_products][:id].to_i
+        already_in = true
+        @order_product = OrderProduct.find(order_product.id)
+        @order_product.save


You find an order_product and then save it to the database without changing anything here.

CheezItMan · 2016-11-07T04:02:00Z

app/controllers/order_products_controller.rb

+
+    if @order_product.save
+      redirect_to '/cart'
+    else


should probably use a named route instead of '/cart'

CheezItMan · 2016-11-07T04:04:56Z

app/controllers/orders_controller.rb

+  #   end
+  # end
+
+  def edit


Yes I think the edit method here should be using session to find the user or using the filter to find the value for the @user attribute.

alyssahursh added 2 commits October 28, 2016 15:28

Copied from beyoncy

cfe6268

Merge pull request #1 from rpavilanis/alyssa

d567acf

Copied from beyoncy

alyssahursh changed the title ~~Beyoncy~~ Beyoncy - Rachel, Lauren, Joanna, and Alyssa Oct 28, 2016

kariabancroft added the parens label Oct 31, 2016

CheezItMan reviewed Nov 7, 2016

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Beyoncy - Rachel, Lauren, Joanna, and Alyssa #39

Beyoncy - Rachel, Lauren, Joanna, and Alyssa #39

alyssahursh commented Oct 28, 2016

alyssahursh commented Oct 28, 2016 •

edited

Loading

rpavilanis commented Oct 28, 2016 •

edited

Loading

CheezItMan left a comment

CheezItMan Oct 30, 2016

CheezItMan Oct 30, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016


		already_in = false

		@order.order_products.each do \|order_product\|

Beyoncy - Rachel, Lauren, Joanna, and Alyssa #39

Are you sure you want to change the base?

Beyoncy - Rachel, Lauren, Joanna, and Alyssa #39

Conversation

alyssahursh commented Oct 28, 2016

alyssahursh commented Oct 28, 2016 • edited Loading

rpavilanis commented Oct 28, 2016 • edited Loading

CheezItMan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alyssahursh commented Oct 28, 2016 •

edited

Loading

rpavilanis commented Oct 28, 2016 •

edited

Loading