Team Puffy Shirts bring you (parens) #37

miriam-cortes · 2016-10-28T22:29:40Z

From the people who brought you the "Charles in Charge" meme, we bring you http://notyetsy.herokuapp.com/

Merchant show and edit

Guests controller

Products branch

…page

Merchant show and edit

Products

Styling

Seeding

Checkout

Reviews

Styling

miriam-cortes · 2016-10-28T22:39:32Z

What helped us stay organized and working together?

I think the fact that we spoke for a while about our working styles before starting the actual work really helped team Puffy Shirts! Even through tough times we had a "work hard, play harder" attitude that helped us push through the tougher moments. I totally loved working with these people, even when they needed time locked away (from me) in a dark room :)

What should you have been doing differently?

More tests? Started working on design upgrades? IDK, really.

What would you recommend to C7?

Take time away from your teammates when you need it so you can reconvene in a more refreshed state of mind. Talk through your merges so everyone in the team knows what was changed- it makes finding things that will break much easier.

What went well?

Everyone pulled their weight; everyone was very proactive and always asked what else they could start working on. It really made the Task Master job easier.

What was most challenging?

The whole order/cart situation. We didn't realize what a HUUUUUUUGE part that was so when Sabrina took it on (by herself) we thought nothing of it. As time passed we finished our individual portions and wanted to help out with hers but it would've taken so much extra time catching us up that there was really nothing we could do immediately.

How do you feel about your project overall?

We rock. I'm glad we were able to end this project on a high note! Seriously, C6 is pretty darn awesome!

wilsab30 · 2016-10-28T22:43:30Z

What helped you stay organized and working together?
We had many check-ins and had a routine of pushing, pull requests, reviewing and merging. This helped us all stay on track and knowing what the next step would be.

What should you have been doing differently?
I don't know that as a group we should have done anything differently. We disagreed, but also laughed, sang and worked it out.

One piece of advice for c7.
Take the time to talk it all out before writing any code . We did and I think that's why we had fun and got stuff done.

What went well technically?
We didn't have large merge conflicts. We keep things pretty contained and were able to workout any problems.

What was most challenging?
The #$%## cart. We had no idea how different that would be from the apps we had built before. I felt so bad about not having more done sooner. I was complicated in so many ways. I wish we had some warning before starting. Maybe we would have broken that part up among a few people.

Overall I think we did a mashing job of it. Not only did we make a really cute site, that works, we also laughed together and voiced appreciation for each other along the way.

ninamutty · 2016-10-28T22:43:43Z

Team Work:

I found the stand-ups helpful in staying organized and I think we did a good job of communicating where each us were in our work - both what we had completed and what we needed to accomplish. I think that we did a good job trouble shooting together as well.
The first week was a little tougher both in stress levels and communication. I was out sick the first Monday (and as a result didn't understand sessions or the cart) so I had a hard time helping with problems until I was able to catch back up. I think we also didn't always know the best way to help each other in the beginning, but that really changed in the second week and the team dynamic felt much more cohesive.
Have two people working on the cart. It seemed like a much bigger part than any of us were anticipating, particularly because the other aspects of the project were more familiar. I think it would have been helpful for two people to understand and work through it (especially in the beginning) and the other two dividing up some of the more familiar problems.

Technical:

I primarily worked on the products and reviews pages and the styling (except for the merchant and cart pages). I felt good about the functionality I added for the products and reviews and how that changed based on if the user was a merchant or not. I also got more familiar with Foundation which I was happy about.
I found the testing challenging and I know I didn't test for all the edge cases. I think I handled the possibilities decently well in the model and controller but didn't test for them which I really wish I had time to do. I also which some aspects the site were a little more responsive, but overall I'm really happy with it!

Overall:
I really enjoyed this project! While we had our low points, I think my team worked well together and I had a lot of fun building NotYetsy. I'm definitely proud of it and the work we did together!

livmaria7891 · 2016-10-28T22:44:56Z

How did your team work together:

What helped you stay organized and working together?
Our team used a trello board to keep an organized 'to do list' and a spread sheet to divide tasks into waves. Every day we reviewed code changes and pull requests as group to make sure there weren't any serious conflicts. We also communicated a lot.
What should you have been doing differently
Even though we utilized a trello board, it got a little disorganized at times. I think we also could have split work differently because some people carried a far heavier load than others.
What would you recommend to C7? Once piece of advice.
Our team made moral a priority. Every time we became frustrated or discouraged our team had silly rituals in place that helped to make us happy. By the end of the project we had grown closer together and enjoyed each others company more rather than being tired of each other and I think that was because we made team happiness our top priority.

Technical

What went well?
We divided the work in such a way that merge conflicts were rare. It really helped to keep our product working most of the time, even when we were merging lots of code.
What was the most challenging?
The most challenging piece was watching Sabrina suffer through her part of the project and none of us having the knowledge to help. We also ran out of time to write thorough tests.

How do you feel about your project overall?
I am very pleased with our project and how well my team worked together. Although our finished product isn't perfect it does just about everything we wanted it to and it looks great.

CheezItMan

@livmaria7891 @wilsab30 @ninamutty @miriam-cortes

Hello Puffy Shirts! I've put in comments & a summary in your weekly progress reports. Overall well done. I particularly liked the Cart, Model Validations & custom methods and the styling.

Things to work on:

Tests (check negative cases especially)
Drying up Views with View Helpers & Partials
Working on access control (preventing users from getting to things they shouldn't.

CheezItMan · 2016-11-07T04:42:12Z

test/models/category_test.rb

+  # test "the truth" do
+  #   assert true
+  # end
+


You should also test if the name is set correctly it's valid.

CheezItMan · 2016-11-07T04:46:38Z

test/models/merchant_test.rb

@@ -0,0 +1,48 @@
+require 'test_helper'
+


You might also include tests for merchants who don't have any orders, or products, etc.

CheezItMan · 2016-11-07T04:49:22Z

test/models/product_test.rb

+  test "Products cannot have a rating less than 0 or greater than 5" do
+    assert products(:glitter).rating = 6
+    assert_not products(:glitter).valid? "Glitter should no longer be valid"
+


How does this work, isn't rating a method?

CheezItMan · 2016-11-07T04:51:37Z

app/controllers/application_controller.rb

+    return lesser_categories
+  end
+
+  def current_cart


It's interesting that you have a different cart for merchant or guest. That will work and it lets you merge carts when they log in finally. Tricky.

CheezItMan · 2016-11-07T04:53:00Z

app/controllers/categories_controller.rb

+  end
+
+  def show
+    @category = Category.find(params[:id].to_i)


What about when you can't find the Category, it's been deleted etc?

CheezItMan · 2016-11-07T04:56:08Z

app/helpers/orders_helper.rb

@@ -0,0 +1,59 @@
+module OrdersHelper
+


Another good use of a view helper

CheezItMan · 2016-11-07T04:58:36Z

app/models/merchant.rb

@@ -0,0 +1,134 @@
+# Merchant Model


This is very very well done. Good use of validations & business logic here!

CheezItMan · 2016-11-07T05:07:02Z

test/controllers/categories_controller_test.rb

@@ -0,0 +1,44 @@
+require 'test_helper'


On your controller tests you should also include some negative cases, what if the user tries to see a category that's been deleted or never existed. What if someone without permission tries to edit a category?

CheezItMan · 2016-11-07T05:07:59Z

test/controllers/sessions_controller_test.rb

@@ -0,0 +1,41 @@
+require 'test_helper'


You probably also want to test the response if a user goes directly to the callback url without going through github.

CheezItMan · 2016-11-07T05:17:27Z

app/views/merchants/show.html.erb

@@ -0,0 +1,61 @@
+<div class="small-12 columns buttons_container row">


Good work on responsiveness. You could DRY up your views a bit by using partials, but well done!

ninamutty and others added 30 commits October 20, 2016 09:17

added add to cart button

ae185e2

Merge pull request #9 from miriam-cortes/merchant_show_and_edit

788c44f

Merchant show and edit

editing cart button

9d25f60

added inventory to product seeds

58a5eb9

merge conflicts

876d0a3

Merge pull request #10 from miriam-cortes/guests_controller

5b4f322

Guests controller

merged master into products

54763aa

Merge pull request #11 from miriam-cortes/products

e53b8f9

Products branch

added pry gem

54dfa56

products and reviews model test complete

34d7357

few things happening

941fb5c

added delete buttons for reviews

60f4c06

review and product controller tests done

9b97ab9

merchant can now login using github and properly links to their show …

b2d6570

…page

categories tests complete, changed line-item fixture to add order_id etc

8d8a14b

category model validation test

38a78ea

Moved methods into model

e193a86

nighttime miriam just doesn't get it

e9c450e

Merge branch 'master' into SessionsController

8889643

Merge branch 'master' into merchant_show_and_edit

420c5a3

merged controller test

6d1a63f

Merge pull request #12 from miriam-cortes/merchant_show_and_edit

ff87495

Merchant show and edit

Merge branch 'master' into SessionsController

d948698

Merge branch 'master' into products

4046fdc

Merge pull request #13 from miriam-cortes/products

9b6e6ab

Products

Merge branch 'master' into SessionsController

8f00b8e

Updated Gemfile for Heroku

a28532d

Updated Gemfile for Heroku

1d3b158

Added gems

1ccbf24

logout button not routing correctly but showing when it's supposed to

13ad3dc

ninamutty and others added 24 commits October 28, 2016 12:32

Merge branch 'master' into styling

a300713

added pictures and more seeds

8f63e4d

fixed merege.

163ea63

Merge branch 'master' into seeding

1afdb42

Merge pull request #45 from miriam-cortes/styling

9a0fe2d

Styling

handled csv merge conflict

29b8095

fixed merge.

7a8a9f8

Merge pull request #46 from miriam-cortes/seeding

8da5937

Seeding

Merge branch 'master' into checkout

684a7d7

Merge pull request #47 from miriam-cortes/checkout

995c1b1

Checkout

edited wedding ring csv

b9275ca

Merge branch 'master' into styling

ada82e4

Gemfile for heroku

ee47cf9

for heroku

3b62a90

reviews 6-9

5de78ed

reviews added

2a87ebb

purchased orders vs customer orders

edab648

Olivia's changes

10f3b85

Merge pull request #49 from miriam-cortes/reviews

a9dd3ba

Reviews

seeds fixed

9baf840

Merge pull request #50 from miriam-cortes/styling

68ea06d

Styling

gemfile for heroku

ade6ce5

seeds

cb85654

checkout button

ac5b16d

kariabancroft added the parens label Oct 31, 2016

CheezItMan reviewed Nov 7, 2016

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Team Puffy Shirts bring you (parens) #37

Team Puffy Shirts bring you (parens) #37

miriam-cortes commented Oct 28, 2016

miriam-cortes commented Oct 28, 2016

wilsab30 commented Oct 28, 2016

ninamutty commented Oct 28, 2016

livmaria7891 commented Oct 28, 2016

CheezItMan left a comment

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

CheezItMan Nov 7, 2016

		@@ -0,0 +1,61 @@
		<div class="small-12 columns buttons_container row">

Team Puffy Shirts bring you (parens) #37

Are you sure you want to change the base?

Team Puffy Shirts bring you (parens) #37

Conversation

miriam-cortes commented Oct 28, 2016

miriam-cortes commented Oct 28, 2016

wilsab30 commented Oct 28, 2016

ninamutty commented Oct 28, 2016

livmaria7891 commented Oct 28, 2016

CheezItMan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment