forked from AdaGold/BankAccounts
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Danielle - BankAccounts Waves 1-3 #9
Open
dschrimm
wants to merge
11
commits into
Ada-C6:master
Choose a base branch
from
dschrimm:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Error when calling owner method in account file.
…h ID and positive balance, handles negative withdrawls, owner can be added after account has been created.
… Account instances, returns an instance of Account where id field matches passed parameter.
…ed to reflect updated owner fields.
…ng accounts with owners.
… return withdraw outside of loop.
…euse super method in savings account.
droberts-sea
pushed a commit
to droberts-sea/BankAccounts
that referenced
this pull request
Mar 3, 2017
Fix some spelling and formatting problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enjoyed the assignment and completed some optional components. I would like to learn about how to combine data from the account and owner files.