Guinevere's Bank Account #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounts to dollars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are Wave 1, 2, and 3 requirements.
I added the Owner class for Wave One, but could never figure out how to merge them in Wave Two.
The MIN_BALANCE logic gets a little weird in the base Account, since it is set to zero, and hence it is possible to open an account with $0 in it.
I stuck to dollar amounts and changed the input from the CSV file to reflect dollars. Resulting were some crummy numbers when the interest method was called.
I also made a MoneyMarket account for Wave Three, which has some pretty convoluted logic...