Shari Meggs BankAccount #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… out in wave 1. This has been tested
…dd the second with a method that would link an account
…e instances in an array
…functionality for withdraw
…the initial balance. Also modified withdraw method as it calculated incorrectly (and deposit) Changed a values to floats
…the very end to dollars. This made it easier to assign different variables and not continue to convert the money as I went along
…re the right deductions were being made
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wave 1: I was able to complete this fairly easily and understood the instructions. I attempted the optional requirement but held off until Wave 2
Wave 2: The baseline requirements were pretty difficult especially find. I was able to visualize what I wanted to do but was unable to put it into code. I realized I didn't understand a lot of the pieces that went into parsing the data.
I overall understood what a CSV was but had issues applying some of that information into practice.
Wave 3: Wave three was a lot more manageable and it made me think about how the whole code fix together. I added some constants and changed the logic of the program as I realized withdraw was not correctly subtracting.
Some doubts: