forked from AdaGold/FarMar
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lisa's FarMar #44
Open
Lisa-Sano
wants to merge
51
commits into
Ada-C5:master
Choose a base branch
from
Lisa-Sano:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lisa's FarMar #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_all method that can create instances from csv files. Added self.all method to Markets class which calls the self.make_all module mixin method. Added a test in market_spec to make sure the self.all method call returns an array.
self.find methods in classes now not needed explicitly, and make_all on the mixin can be called using self as the default for Class calling it
… for both methods to spec file.
…ests to spec file
…le class. added specs to test both methods.
…t are associated with a particular market by market_id
…eader for :vendor_id on Product class. added specs.
… cents. Added spec to test
…ific instance matching vendor_id or product_id. added specs to test
…. Returns collection of sales of either vendor or product types.
… of all instances between a given time range. added specs to test
…of products using product's vendor_id and vendor's market_id. Added specs to test it out.
…st of all markets whose name or associated vendor name contains the searched term. added specs to test in market_spec.rb.
…most items at a particular market. added specs.
…ce or an array of instances
…irb. it seems that the Time class doesn't always include the parse method, so requiring 'time' covers bases.
…ales for a particular market. added specs. updated specs to test #preferred_vendor method too.
…rray of all sales on a particular date
…nue for all sales on a specific date
…ional (default value nil). returns all revenue from a specific date
…hat sold something that day are represented in case those with 0 revenue simply weren't present at the market. added and updated specs to test out changes and date addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solo project by Lisa Rolczynski.
require 'csv' and require 'date'
I finished all that FarMar::Market optionals, the mixin optional, and a couple of the FarMar::Vendor optionals.