FarMar, the Mars of Fars #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ach(passing of course)
…itialize. All find and all methods functional
…ses to inherit common behavior. Cool
…vior, altered far_mar to require additional necessary class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed primary requirements, plus optional requirements II. Did NOT do optional I.
I felt like it was all very reasonable, the most difficult piece being calculating time. I calculated dates successfully, but did not implement a solution for finding time more specifically than the date. If I were to refactor/redo, I'd either learn up some DateTime or maybe look into seeing if the Chronic gem has anything useful for calculating down to minutes.
I had 100% coverage on all of my tests, but I don't think they're good tests. I put p statements in my code so that tests would print out their return values so I could make sure they visually were what I expected, but my tests aren't specific enough I think.