rachael water class #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w medias are not saving properly. Need to add flash.
…aving. creating stylesheet.css
…lem. working on model tests
…d for a work on work show page.
CheezItMan
reviewed
Nov 17, 2020
There was a problem hiding this comment.
Media Ranker
Functional Requirements: Manual Testing
| Criteria | yes/no |
|---|---|
| Before logging in | -- |
| 1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight | |
| 2. Can go into a work's show page | ✔️ |
| 3. Verify unable to vote on a work, and get a flash message | ✔️ |
| 4. Can edit this work successfully, and get a flash message | ✔️, However I don't have an edit link. |
| 5. Can go to "View all media" page and see three lists of works, sorted by vote | ✔ |
| 6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message | |
| 7. Can create a new work successfully. Note the URL for this work's show page | ✔️ |
| 8. Can delete this work successfully | ✔️ |
| 9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view) | ✔️ |
| 10. Verify that the "View all users" page lists no users | ✔️ |
| Log in | -- |
| 11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons | ✔️ |
| 12. Your username is listed in "View all users" page | ✔️ |
| 13. Verify that number of votes determines the Media Spotlight | ✔️ |
| 14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page | ✔️ |
| 15. Voting on the same work twice produces an error and flash message, and there is no extra vote | ✔️ |
| Log out | -- |
| 16. Logging out showed a flash message and changed the UI | ✔️ |
| 17. Logging in as a new user creates a new user | ✔️ |
| 18. Logging in as an already existing user has a specific flash message | ✔️ |
Major Learning Goals/Code Review
| Criteria | yes/no |
|---|---|
| 1. Sees the full development cycle including deployment, and the app is deployed to Heroku | ✔️ |
| 2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker | |
| 3. Practices git with at least 25 small commits and meaningful commit messages | ✔️ |
Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code
| Criteria | yes/no |
|---|---|
4. Routes file uses resources for works |
✔️ |
| 5. Routes file shows intention in limiting routes for voting, log-in functionality, and users | ✔️ |
| 6. The homepage view, all media view, and new works view use semantic HTML | ✔️, for the most part yes. |
| 7. The homepage view, all media view, and new works view use partials when appropriate | |
8. The model for media (likely named work.rb) has_many votes |
✔️ |
| 9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category | |
10. Some controller, likely the ApplicationController, has a controller filter for finding a logged in user |
|
11. Some controller, likely the WorksController, has a controller filter for finding a work |
|
12. The WorksController uses strong params |
✔️ |
13. The WorksController's code style is clean, and focused on working with requests, responses, params, session, flash |
✔️, for the most part, see my inline comments |
Testing Rails Apps
| Criteria | yes/no |
|---|---|
| 14. There are valid fixtures files used for users, votes, and works | ✔️, it's there with one bug |
| 15. User model has tests with sections on validations (valid and invalid) and relationships (has votes) | |
| 16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote) | ✔️, see my inline comments for errrors |
| 17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes) | ✔️, see my inline comments for missing items |
| 18. Work model has tests with a section on all business logic methods in the model, including their edge cases | ✔️, see my inline comments for errors on tests |
Overall Feedback
| Overall Feedback | Criteria | yes/no |
|---|---|---|
| Yellow (Approaches Standards) | 12+ in Functional Requirements: Manual Testing && 11+ in Code Review, or the instructor judges that this project needs special attention | 💛 |
Code Style Bonus Awards
Was the code particularly impressive in code style for any of these reasons (or more...?)
| Quality | Yes? |
|---|---|
| Perfect Indentation | ✅ |
| Logical/Organized | ✅ |
Summary
It's clear you struggled a bit with testing and displaying validation errors and styling to match the site. You do have the basic functionality in place. Thus this is a yellow. Take a look at my inline comments and let me know what questions you have. Specifically take a look at your model methods, testing comments and your flash notices. These are the things to work on.
Comment on lines
+28
to
+34
| @work = works(:movie) | ||
|
|
||
| @works = Work.all | ||
|
|
||
| result = @works.spotlight | ||
|
|
||
| expect(result).must_be_instance_of Work |
There was a problem hiding this comment.
Just a note, if the variable is only used inside the it block. You don't need to make it an instance variable
Suggested change
| @work = works(:movie) | |
| @works = Work.all | |
| result = @works.spotlight | |
| expect(result).must_be_instance_of Work | |
| work = works(:movie) | |
| works = Work.all | |
| result = Work.spotlight | |
| expect(result).must_be_instance_of Work |
|
|
||
| result = @works.sort_votes | ||
|
|
||
| expect(result.first.title).must_be_same_as @work.title |
There was a problem hiding this comment.
must_be_same_as compares to see if they are the same object (object_id) and not the same value
Suggested change
| expect(result.first.title).must_be_same_as @work.title | |
| expect(result.first.title).must_equal @work.title |
|
|
||
| result = @works.spotlight | ||
|
|
||
| expect(result.title).must_be_same_as "Normal People" |
There was a problem hiding this comment.
must_be_same_as compares to see if they are the same object (object_id) and not the same value
Suggested change
| expect(result.title).must_be_same_as "Normal People" | |
| expect(result.title).must_equal "Normal People" |
| user = users(:test_user) | ||
| @vote = Vote.new(user.id, work.id) | ||
|
|
||
| expect(@vote.work_id).must_be_same_as work.id |
There was a problem hiding this comment.
must_be_same_as compares to see if they are the same object_id, not the same value.
Better to do:
Suggested change
| expect(@vote.work_id).must_be_same_as work.id | |
| expect(@vote.work_id).must_equal work.id |
| user = users(:test_user) | ||
| @vote = Vote.new(user.id, work.id) | ||
|
|
||
| expect(vote.user_id).must_be_same_as user.id |
There was a problem hiding this comment.
must_be_same_as compares to see if they are the same object_id, not the same value.
Suggested change
| expect(vote.user_id).must_be_same_as user.id | |
| expect(vote.user_id).must_equal user.id |
Comment on lines
+35
to
+38
| <strong class="<%= name %>"> | ||
| <%= message %> | ||
| </strong> | ||
| <% end %> |
There was a problem hiding this comment.
This is just a suggestion to iterate through all the validation errors.
Suggested change
| <strong class="<%= name %>"> | |
| <%= message %> | |
| </strong> | |
| <% end %> | |
| <% if name == :errors %> | |
| <%= flash[name].each do |field, messages| %> | |
| <%= "#{field}: #{messages} %> | |
| <% end %> | |
| <% else %> | |
| <strong class="<%= name %>"> | |
| <%= message %> | |
| </strong> | |
| <% end %> | |
| <% end %> |
| redirect_to works_path | ||
| end | ||
| if @work.nil? | ||
| head :not_found |
There was a problem hiding this comment.
Maybe better from now on to redirect and provide a flash notice.
|
|
||
| root 'homepages#index' | ||
|
|
||
| get '/homepages', to: 'homepages#index', as: 'homepages' |
There was a problem hiding this comment.
You don't need this
Suggested change
| get '/homepages', to: 'homepages#index', as: 'homepages' |
| # patch '/works/:id', to: 'works#update' | ||
| # get '/works/:id', to: 'works#show', as: 'work' | ||
| # delete '/works/:id', to: 'works#destroy' | ||
| post 'works/:id', to: 'works#vote', as: 'vote_work' |
There was a problem hiding this comment.
I'd suggest instead making this a nested route.
resources :works do
resources :votes, only: [:create]
end| @@ -0,0 +1,57 @@ | |||
| <body> | |||
There was a problem hiding this comment.
Body should be in the application.html.erb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media Ranker
Congratulations! You're submitting your assignment!
Comprehension Questions
sessionandflash? What is the difference between them?Assignment Submission: Media Ranker
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
sessionandflash? What is the difference between them?