Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earth - Kal #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
GEM
remote: https://rubygems.org/
specs:
ansi (1.5.0)
builder (3.2.4)
coderay (1.1.3)
method_source (1.0.0)
minitest (5.14.2)
minitest-reporters (1.4.2)
ansi
builder
minitest (>= 5.0)
ruby-progressbar
minitest-skip (0.0.3)
minitest (~> 5.0)
minitest-spec (0.0.2.1)
minitest (>= 3.0)
pry (0.13.1)
coderay (~> 1.1)
method_source (~> 1.0)
rake (13.0.1)
ruby-progressbar (1.10.1)

PLATFORMS
ruby

DEPENDENCIES
minitest
minitest-reporters
minitest-skip
minitest-spec
pry
rake

BUNDLED WITH
2.1.4
61 changes: 42 additions & 19 deletions lib/linked_list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,39 +7,62 @@ def initialize
@head = nil
end

# Time complexity - ?
# Space complexity - ?
# Time complexity O(n)
# Space complexity - O(1)
def add_first(data)
Comment on lines +10 to 12

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 But time complexity is O(1)


@head = Node.new(data, @head)
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def get_first
Comment on lines +16 to 18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but time complexity is O(1)


return @head.nil? ? nil : @head.data
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def length
Comment on lines +22 to 24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return 0
length = 0
curr = @head
until curr.nil?
curr = curr.next
length += 1
end
return length
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def add_last(data)
Comment on lines +34 to 36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


curr = @head
if curr.nil?
@head = Node.new(data, nil)
return
end
until curr.next == nil
curr = curr.next
end
curr.next = Node.new(data, nil)
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def get_last
Comment on lines +48 to 50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


return if @head.nil?
curr = @head
until curr.next.nil?
curr = curr.next
end
return curr.data
end

# Time complexity - ?
# Space complexity - ?
# Time complexity - O(n)
# Space complexity - O(1)
def get_at_index(index)
Comment on lines +59 to 61

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Very compact


curr = @head
index.times do
curr.nil? ? return : curr = curr.next
end
return curr.data
end
end
end
8 changes: 4 additions & 4 deletions test/linked_list_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
end
end

xdescribe 'add_first & get_first' do
describe 'add_first & get_first' do
it 'can add values to an empty list' do
# Act
@list.add_first(3)
Expand Down Expand Up @@ -51,7 +51,7 @@
end
end

xdescribe "length" do
describe "length" do
it "will return 0 for an empty list" do
expect(@list.length).must_equal 0
end
Expand All @@ -66,7 +66,7 @@
end
end

xdescribe "addLast & getLast" do
describe "addLast & getLast" do
it "will add to the front if the list is empty" do
@list.add_last(1)
expect(@list.get_first).must_equal 1
Expand All @@ -93,7 +93,7 @@
end
end

xdescribe 'get_at_index' do
describe 'get_at_index' do
it 'returns nil if the index is outside the bounds of the list' do
expect(@list.get_at_index(3)).must_be_nil
end
Expand Down